Skip to content

Commit 688f087

Browse files
committed
test: Update test skipping for K8s 1.35
Signed-off-by: Ciprian Hacman <[email protected]>
1 parent 584d67e commit 688f087

File tree

1 file changed

+3
-24
lines changed

1 file changed

+3
-24
lines changed

tests/e2e/pkg/tester/skip_regex.go

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -88,33 +88,11 @@ func (t *Tester) setSkipRegexFlag() error {
8888
// < 36 so we look at this again
8989
skipRegex += "|Services.should.support.externalTrafficPolicy.Local.for.type.NodePort"
9090
// https://github.com/kubernetes/kubernetes/issues/129221
91-
// < 36 so we look at this again
92-
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
93-
// < 36 so we look at this again
94-
skipRegex += "|Networking.Granular.Checks:.Services.should.function.for.service.endpoints.using.hostNetwork"
95-
}
96-
97-
} else if networking.Calico != nil {
98-
if cluster.Spec.LegacyCloudProvider == "gce" && k8sVersion.Minor < 35 {
99-
// < 35 so we look at this again
100-
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
101-
}
102-
} else if networking.Flannel != nil {
103-
if k8sVersion.Minor < 36 {
104-
// < 36 so we look at this again
105-
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
10691
}
10792
} else if networking.KubeRouter != nil {
10893
skipRegex += "|should set TCP CLOSE_WAIT timeout|should check kube-proxy urls"
109-
if k8sVersion.Minor < 36 {
110-
// < 36 so we look at this again
111-
skipRegex += "|Networking.Granular.Checks:.Services.should.function.for.service.endpoints.using.hostNetwork"
112-
// < 36 so we look at this again
113-
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
114-
}
11594
} else if networking.Kubenet != nil {
11695
skipRegex += "|Services.*affinity"
117-
skipRegex += "|Services.should.function.for.service.endpoints.using.hostNetwork"
11896
}
11997

12098
if cluster.Spec.LegacyCloudProvider == "digitalocean" {
@@ -135,9 +113,10 @@ func (t *Tester) setSkipRegexFlag() error {
135113
// ref: https://github.com/kubernetes/kubernetes/issues/123255
136114
// ref: https://github.com/kubernetes/kubernetes/issues/121018
137115
// ref: https://github.com/kubernetes/kubernetes/pull/126896
138-
// < 35 so we look at this again
139-
if k8sVersion.Minor < 35 {
116+
// < 36 so we look at this again
117+
if k8sVersion.Minor < 36 {
140118
skipRegex += "|Services.should.function.for.service.endpoints.using.hostNetwork"
119+
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
141120
}
142121

143122
for _, subnet := range cluster.Spec.Subnets {

0 commit comments

Comments
 (0)