Refactor interface type check to more idiomatic syntax

Author: rramkumar1

upup/pkg/fi/cloudup/awstasks/classic_load_balancer.go

@@ -38,7 +38,7 @@ import (
 
 // LoadBalancer manages an ELB.  We find the existing ELB using the Name tag.
 
-var _ DNSTarget = &ClassicLoadBalancer{}
+var _ DNSTarget = (*ClassicLoadBalancer)(nil)
 
 // +kops:fitask
 type ClassicLoadBalancer struct {

upup/pkg/fi/cloudup/awstasks/network_load_balancer.go

@@ -39,7 +39,7 @@ import (
 )
 
 // NetworkLoadBalancer manages an NLB.  We find the existing NLB using the Name tag.
-var _ DNSTarget = &NetworkLoadBalancer{}
+var _ DNSTarget = (*NetworkLoadBalancer)(nil)
 
 // +kops:fitask
 type NetworkLoadBalancer struct {

upup/pkg/fi/cloudup/awstasks/securitygroup.go

@@ -435,7 +435,7 @@ type PortRemovalRule struct {
 	ToPort   int
 }
 
-var _ RemovalRule = &PortRemovalRule{}
+var _ RemovalRule = (*PortRemovalRule)(nil)
 
 func (r *PortRemovalRule) String() string {
 	return fi.DebugAsJsonString(r)

upup/pkg/fi/cloudup/azure/applicationsecuritygroup.go

@@ -37,7 +37,7 @@ type ApplicationSecurityGroupsClientImpl struct {
 	c *network.ApplicationSecurityGroupsClient
 }
 
-var _ ApplicationSecurityGroupsClient = &ApplicationSecurityGroupsClientImpl{}
+var _ ApplicationSecurityGroupsClient = (*ApplicationSecurityGroupsClientImpl)(nil)
 
 func (c *ApplicationSecurityGroupsClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName, applicationSecurityGroupName string, parameters network.ApplicationSecurityGroup) (*network.ApplicationSecurityGroup, error) {
 	future, err := c.c.BeginCreateOrUpdate(ctx, resourceGroupName, applicationSecurityGroupName, parameters, nil)

upup/pkg/fi/cloudup/azure/disk.go

@@ -35,7 +35,7 @@ type disksClientImpl struct {
 	c *compute.DisksClient
 }
 
-var _ DisksClient = &disksClientImpl{}
+var _ DisksClient = (*disksClientImpl)(nil)
 
 func (c *disksClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName, diskName string, parameters compute.Disk) (*compute.Disk, error) {
 	future, err := c.c.BeginCreateOrUpdate(ctx, resourceGroupName, diskName, parameters, nil)

upup/pkg/fi/cloudup/azure/loadbalancer.go

@@ -39,7 +39,7 @@ type loadBalancersClientImpl struct {
 	c *network.LoadBalancersClient
 }
 
-var _ LoadBalancersClient = &loadBalancersClientImpl{}
+var _ LoadBalancersClient = (*loadBalancersClientImpl)(nil)
 
 func (c *loadBalancersClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName, loadBalancerName string, parameters network.LoadBalancer) (*network.LoadBalancer, error) {
 	future, err := c.c.BeginCreateOrUpdate(ctx, resourceGroupName, loadBalancerName, parameters, nil)

upup/pkg/fi/cloudup/azure/natgateway.go

@@ -37,7 +37,7 @@ type NatGatewaysClientImpl struct {
 	c *network.NatGatewaysClient
 }
 
-var _ NatGatewaysClient = &NatGatewaysClientImpl{}
+var _ NatGatewaysClient = (*NatGatewaysClientImpl)(nil)
 
 func (c *NatGatewaysClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName, natGatewayName string, parameters network.NatGateway) (*network.NatGateway, error) {
 	future, err := c.c.BeginCreateOrUpdate(ctx, resourceGroupName, natGatewayName, parameters, nil)

upup/pkg/fi/cloudup/azure/networkinterface.go

@@ -33,7 +33,7 @@ type networkInterfacesClientImpl struct {
 	c *network.InterfacesClient
 }
 
-var _ NetworkInterfacesClient = &networkInterfacesClientImpl{}
+var _ NetworkInterfacesClient = (*networkInterfacesClientImpl)(nil)
 
 func (c *networkInterfacesClientImpl) ListScaleSetsNetworkInterfaces(ctx context.Context, resourceGroupName, vmssName string) ([]*network.Interface, error) {
 	var l []*network.Interface

upup/pkg/fi/cloudup/azure/networksecuritygroup.go

@@ -37,7 +37,7 @@ type NetworkSecurityGroupsClientImpl struct {
 	c *network.SecurityGroupsClient
 }
 
-var _ NetworkSecurityGroupsClient = &NetworkSecurityGroupsClientImpl{}
+var _ NetworkSecurityGroupsClient = (*NetworkSecurityGroupsClientImpl)(nil)
 
 func (c *NetworkSecurityGroupsClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName, NetworkSecurityGroupName string, parameters network.SecurityGroup) (*network.SecurityGroup, error) {
 	future, err := c.c.BeginCreateOrUpdate(ctx, resourceGroupName, NetworkSecurityGroupName, parameters, nil)

upup/pkg/fi/cloudup/azure/publicipaddress.go

@@ -37,7 +37,7 @@ type publicIPAddressesClientImpl struct {
 	c *network.PublicIPAddressesClient
 }
 
-var _ PublicIPAddressesClient = &publicIPAddressesClientImpl{}
+var _ PublicIPAddressesClient = (*publicIPAddressesClientImpl)(nil)
 
 func (c *publicIPAddressesClientImpl) CreateOrUpdate(ctx context.Context, resourceGroupName, publicIPAddressName string, parameters network.PublicIPAddress) (*network.PublicIPAddress, error) {
 	future, err := c.c.BeginCreateOrUpdate(ctx, resourceGroupName, publicIPAddressName, parameters, nil)