Refactor interface type check to more idiomatic syntax

Author: rramkumar1

upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go

@@ -108,9 +108,9 @@ type AutoscalingGroup struct {
 	deletions []fi.CloudupDeletion
 }
 
-var _ fi.CloudupProducesDeletions = &AutoscalingGroup{}
-var _ fi.CompareWithID = &AutoscalingGroup{}
-var _ fi.CloudupTaskNormalize = &AutoscalingGroup{}
+var _ fi.CloudupProducesDeletions = (*AutoscalingGroup)(nil)
+var _ fi.CompareWithID = (*AutoscalingGroup)(nil)
+var _ fi.CloudupTaskNormalize = (*AutoscalingGroup)(nil)
 
 // CompareWithID returns the ID of the ASG
 func (e *AutoscalingGroup) CompareWithID() *string {
@@ -1108,7 +1108,7 @@ type deleteAutoscalingTargetGroupAttachment struct {
 	targetGroupARN       string
 }
 
-var _ fi.CloudupDeletion = &deleteAutoscalingTargetGroupAttachment{}
+var _ fi.CloudupDeletion = (*deleteAutoscalingTargetGroupAttachment)(nil)
 
 func buildDeleteAutoscalingTargetGroupAttachment(autoScalingGroupName string, targetGroupARN string) *deleteAutoscalingTargetGroupAttachment {
 	d := &deleteAutoscalingTargetGroupAttachment{}

upup/pkg/fi/cloudup/awstasks/autoscalinggroup_fitask.go

@@ -48,7 +48,7 @@ type AutoscalingLifecycleHook struct {
 	Enabled *bool
 }
 
-var _ fi.CompareWithID = &AutoscalingLifecycleHook{}
+var _ fi.CompareWithID = (*AutoscalingLifecycleHook)(nil)
 
 func (h *AutoscalingLifecycleHook) CompareWithID() *string {
 	return h.Name

upup/pkg/fi/cloudup/awstasks/autoscalinglifecyclehook.go

@@ -181,7 +181,7 @@ func (i *BlockDeviceMapping) ToLaunchTemplateBootDeviceRequest(deviceName string
 	return o
 }
 
-var _ fi.CloudupHasDependencies = &BlockDeviceMapping{}
+var _ fi.CloudupHasDependencies = (*BlockDeviceMapping)(nil)
 
 // GetDependencies is for future use
 func (i *BlockDeviceMapping) GetDependencies(tasks map[string]fi.CloudupTask) []fi.CloudupTask {

upup/pkg/fi/cloudup/awstasks/autoscalinglifecyclehook_fitask.go

@@ -38,7 +38,7 @@ import (
 
 // LoadBalancer manages an ELB.  We find the existing ELB using the Name tag.
 
-var _ DNSTarget = &ClassicLoadBalancer{}
+var _ DNSTarget = (*ClassicLoadBalancer)(nil)
 
 // +kops:fitask
 type ClassicLoadBalancer struct {
@@ -79,8 +79,8 @@ type ClassicLoadBalancer struct {
 	WellKnownServices []wellknownservices.WellKnownService
 }
 
-var _ fi.CompareWithID = &ClassicLoadBalancer{}
-var _ fi.CloudupTaskNormalize = &ClassicLoadBalancer{}
+var _ fi.CompareWithID = (*ClassicLoadBalancer)(nil)
+var _ fi.CloudupTaskNormalize = (*ClassicLoadBalancer)(nil)
 
 func (e *ClassicLoadBalancer) CompareWithID() *string {
 	return e.Name
@@ -109,7 +109,7 @@ func (e *ClassicLoadBalancerListener) mapToAWS(loadBalancerPort int32) elbtypes.
 	return l
 }
 
-var _ fi.CloudupHasDependencies = &ClassicLoadBalancerListener{}
+var _ fi.CloudupHasDependencies = (*ClassicLoadBalancerListener)(nil)
 
 func (e *ClassicLoadBalancerListener) GetDependencies(tasks map[string]fi.CloudupTask) []fi.CloudupTask {
 	return nil
@@ -342,7 +342,7 @@ func (e *ClassicLoadBalancer) Find(c *fi.CloudupContext) (*ClassicLoadBalancer,
 	return actual, nil
 }
 
-var _ fi.HasAddress = &ClassicLoadBalancer{}
+var _ fi.HasAddress = (*ClassicLoadBalancer)(nil)
 
 // GetWellKnownServices implements fi.HasAddress::GetWellKnownServices.
 // It indicates which services we support with this address (likely attached to a load balancer).

upup/pkg/fi/cloudup/awstasks/block_device_mappings.go

@@ -31,7 +31,7 @@ type ClassicLoadBalancerHealthCheck struct {
 	Timeout  *int32
 }
 
-var _ fi.CloudupHasDependencies = &ClassicLoadBalancerListener{}
+var _ fi.CloudupHasDependencies = (*ClassicLoadBalancerListener)(nil)
 
 func (e *ClassicLoadBalancerHealthCheck) GetDependencies(tasks map[string]fi.CloudupTask) []fi.CloudupTask {
 	return nil

upup/pkg/fi/cloudup/awstasks/classic_load_balancer.go

@@ -47,7 +47,7 @@ type DHCPOptions struct {
 	Tags map[string]string
 }
 
-var _ fi.CompareWithID = &DHCPOptions{}
+var _ fi.CompareWithID = (*DHCPOptions)(nil)
 
 func (e *DHCPOptions) CompareWithID() *string {
 	return e.ID