Skip to content

Commit edde1da

Browse files
authored
Merge pull request #18300 from hakman/automated-cherry-pick-of-#18298-upstream-release-1.34
Automated cherry pick of #18298: dns-controller: make priorityClassName configurable
2 parents b0904e3 + 3e00347 commit edde1da

12 files changed

Lines changed: 45 additions & 1 deletion

File tree

k8s/crds/kops.k8s.io_clusters.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1461,6 +1461,11 @@ spec:
14611461
description: Disable indicates we do not wish to run the dns-controller
14621462
addon
14631463
type: boolean
1464+
priorityClassName:
1465+
description: |-
1466+
PriorityClassName overrides the priorityClassName on the dns-controller pod.
1467+
Defaults to "system-cluster-critical" when unset.
1468+
type: string
14641469
provider:
14651470
description: |-
14661471
Provider determines which implementation of ExternalDNS to use.

pkg/apis/kops/cluster.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -648,6 +648,9 @@ type ExternalDNSConfig struct {
648648
// 'dns-controller' will use kOps DNS Controller.
649649
// 'external-dns' will use kubernetes-sigs/external-dns.
650650
Provider ExternalDNSProvider `json:"provider,omitempty"`
651+
// PriorityClassName overrides the priorityClassName on the dns-controller pod.
652+
// Defaults to "system-cluster-critical" when unset.
653+
PriorityClassName *string `json:"priorityClassName,omitempty"`
651654
}
652655

653656
// EtcdProviderType describes etcd cluster provisioning types (Standalone, Manager)

pkg/apis/kops/fieldmap.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,5 @@ var clusterFieldMappings = []struct {
8282
{V1Alpha2: "spec.masterPublicName", V1Alpha3: "spec.api.publicName"},
8383
{V1Alpha2: "spec.topology.dns.type", V1Alpha3: "spec.networking.topology.dns"},
8484
{V1Alpha2: "spec.externalDns.provider", V1Alpha3: "spec.externalDNS.provider"},
85+
{V1Alpha2: "spec.externalDns.priorityClassName", V1Alpha3: "spec.externalDNS.priorityClassName"},
8586
}

pkg/apis/kops/v1alpha2/cluster.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -628,6 +628,9 @@ type ExternalDNSConfig struct {
628628
// 'dns-controller' will use kOps DNS Controller.
629629
// 'external-dns' will use kubernetes-sigs/external-dns.
630630
Provider ExternalDNSProvider `json:"provider,omitempty"`
631+
// PriorityClassName overrides the priorityClassName on the dns-controller pod.
632+
// Defaults to "system-cluster-critical" when unset.
633+
PriorityClassName *string `json:"priorityClassName,omitempty"`
631634
}
632635

633636
// EtcdProviderType describes etcd cluster provisioning types (Standalone, Manager)

pkg/apis/kops/v1alpha2/zz_generated.conversion.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/kops/v1alpha2/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/kops/v1alpha3/cluster.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,9 @@ type ExternalDNSConfig struct {
611611
// 'dns-controller' will use kOps DNS Controller.
612612
// 'external-dns' will use kubernetes-sigs/external-dns.
613613
Provider ExternalDNSProvider `json:"provider,omitempty"`
614+
// PriorityClassName overrides the priorityClassName on the dns-controller pod.
615+
// Defaults to "system-cluster-critical" when unset.
616+
PriorityClassName *string `json:"priorityClassName,omitempty"`
614617
}
615618

616619
// EtcdClusterSpec is the etcd cluster specification

pkg/apis/kops/v1alpha3/zz_generated.conversion.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/kops/v1alpha3/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/kops/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)