Unnecessary messages during "kops reconcile cluster"

[stl-victor-sudakov]

/kind bug

1. What kops version are you running? The command kops version, will display
this information.

v1.31.0

2. What Kubernetes version are you running? kubectl version will print the
version if a cluster is running or provide the Kubernetes version specified as
a kops flag.

v1.31.6

3. What cloud provider are you using?

AWS

4. What commands did you run? What is the simplest way to reproduce this issue?

kops upgrade cluster --yes && kops reconcile cluster --yes

5. What happened after the commands executed?

The execution was successful but the kops console output was full of warnings like Changes may require instances to restart: kops rolling-update cluster.

6. What did you expect to happen?

I think these messages should not be printed because the "kops reconcile cluster" command is expected tto be self-sufficient and running other commands after it is not required. So these messages can be misleading, especially to new users.

7. Please provide your cluster manifest. Execute
kops get --name my.example.com -o yaml to display your cluster manifest.
You may want to remove your cluster name and other sensitive information.

N/A

[rifelpet]

I improved this in #17282 which will be in the next batch of patch releases

[stl-victor-sudakov]

I improved this in #17282 which will be in the next batch of patch releases

Great news!

Out of curiosity, why was the "Detected single-control-plane cluster; won't detach before draining" message removed?

[rifelpet]

That was unrelated to reconcile specifically, it just wasn't particularly useful.

[stl-victor-sudakov]

That was unrelated to reconcile specifically, it just wasn't particularly useful.

As a person running some single-control-plane clusters since the time when there was no special treatment of such clusters, I used to find the message comforting :-)