kubectl plugin list does not detect overshadowed plugins on Windows

[kfess]

What happened:

kubectl plugin list fails to detect overshadowed plugins on Windows because plugin binary names are extracted using strings.Split(path, "/"), which does not recognize \ as a path separator.

What you expected to happen:

kubectl plugin list should correctly detect overshadowed plugins regardless of OS.

How to reproduce it (as minimally and precisely as possible):

1. On Windows, place two plugins with the same name in different directories in PATH:
   • C:\path1\kubectl-foo.exe
   • C:\path2\kubectl-foo.exe
2. kubectl plugin list
3. No overshadow warning is shown

Anything else we need to know?:

The issue is in staging/src/k8s.io/kubectl/pkg/cmd/plugin/plugin.go:

segs := strings.Split(path, "/")
binName := segs[len(segs)-1]

This should be replaced with OS-independent method.

Environment:

• OS: Windows

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kfess]

/assign
/sig cli

[Pnkcaht]

@kfess Hi, sorry to bother you, I'm an open source engineer and active Docker contributor, can I help clean up the open issues?
Anyway, thank you and sorry :)

[kfess]

Hi @Pnkcaht, thank you for your interest in contributing. I've already submitted a PR (#136689) to fix this issue, so I'm not sure what you're offering to help with. What specifically are you offering to help with?

[Pnkcaht]

Hi @Pnkcaht, thank you for your interest in contributing. I've already submitted a PR (#136689) to fix this issue, so I'm not sure what you're offering to help with. What specifically are you offering to help with?

@kfess I'm referring to the general topic. I won't do that one because you've already submitted a pull request.

[kfess]

@Pnkcaht Thank you for clarifying. I'm just a Kubernetes member who happened to find and fix this issue. I'm not a SIG CLI maintainer. You might want to check the SIG CLI GitHub discussions or Slack channel to see where help is needed. Good luck!

[Pnkcaht]

@Pnkcaht Thank you for clarifying. I'm just a Kubernetes member who happened to find and fix this issue. I'm not a SIG CLI maintainer. You might want to check the SIG CLI GitHub discussions or Slack channel to see where help is needed. Good luck!

Ok, thanks :)