Skip to content

Commit abdbc5b

Browse files
ComradeProgrammerspowelljr
authored andcommitted
Apply suggestions from code review
Co-authored-by: Steven Powell <[email protected]>
1 parent 3c42f1c commit abdbc5b

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

pkg/minikube/tunnel/registry.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,10 @@ func (r *persistentRegistry) Register(tunnel *ID) (rerr error) {
8787

8888
alreadyExists := false
8989
for i, t := range tunnels {
90-
// it is allowed for multiple minikube clusters to have multiple tunnels simultaneously
91-
// it is possible that an old tunnel from an old profile has duplicated route information
92-
// so we need to check both machine name and route information
90+
// It is allowed for multiple minikube clusters to have multiple
91+
// tunnels simultaneously. It is possible that an old tunnel
92+
// from an old profile has duplicated route information so we
93+
// need to check both machine name and route information.
9394
if tunnel.MachineName == t.MachineName && t.Route.Equal(tunnel.Route) {
9495
isRunning, err := checkIfRunning(t.Pid)
9596
if err != nil {

site/content/en/docs/contrib/tests.en.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@ asserts that there are no unexpected errors displayed in minikube command output
115115
are functionality tests which can safely share a profile in parallel
116116

117117
## TestFunctionalNewestKubernetes
118-
are functionality run functional tests using NewestKubernetesVersion
118+
are functionality run functional tests using
119+
NewestKubernetesVersion
119120

120121
#### validateNodeLabels
121122
checks if minikube cluster is created with correct kubernetes's node label

test/integration/functional_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ func TestFunctional(t *testing.T) {
7777
testFunctional(t, "")
7878
}
7979

80-
// TestFunctionalNewestKubernetes are functionality run functional tests using NewestKubernetesVersion
80+
// TestFunctionalNewestKubernetes are functionality run functional tests using
81+
// NewestKubernetesVersion
8182
func TestFunctionalNewestKubernetes(t *testing.T) {
8283
if strings.Contains(*startArgs, "--kubernetes-version") || constants.NewestKubernetesVersion == constants.DefaultKubernetesVersion {
8384
t.Skip()

0 commit comments

Comments
 (0)