diff --git a/site/content/en/docs/contrib/tests.en.md b/site/content/en/docs/contrib/tests.en.md index 38faa568648d..c01d4f3bdece 100644 --- a/site/content/en/docs/contrib/tests.en.md +++ b/site/content/en/docs/contrib/tests.en.md @@ -133,7 +133,9 @@ Steps: runs tests on all the `minikube image` commands, ex. `minikube image load`, `minikube image list`, etc. Steps: -- Make sure image building works by `minikube image build` +- Build an image with `minikube image build` using `test/integration/testdata/build/Dockerfile` +- Add `content.txt` from the build context into a `gcr.io/k8s-minikube/busybox` image and tag it as `localhost/my-image:` +- Start `buildkitd` on demand inside minikube only when the build runs, then verify the new image exists in the cluster runtime - Make sure image loading from Docker daemon works by `minikube image load --daemon` - Try to load image already loaded and make sure `minikube image load --daemon` works - Make sure a new updated tag works by `minikube image load --daemon` diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go index d013ef14c638..048cae83e1cf 100644 --- a/test/integration/functional_test.go +++ b/test/integration/functional_test.go @@ -315,7 +315,9 @@ func validateImageCommands(ctx context.Context, t *testing.T, profile string) { runImageList(ctx, t, profile, "ImageListJson", "json", "[\"%s") runImageList(ctx, t, profile, "ImageListYaml", "yaml", "- %s") - // docs: Make sure image building works by `minikube image build` + // docs: Build an image with `minikube image build` using `test/integration/testdata/build/Dockerfile` + // docs: Add `content.txt` from the build context into a `gcr.io/k8s-minikube/busybox` image and tag it as `localhost/my-image:` + // docs: Start `buildkitd` on demand inside minikube only when the build runs, then verify the new image exists in the cluster runtime t.Run("ImageBuild", func(t *testing.T) { MaybeParallel(t)