-
Notifications
You must be signed in to change notification settings - Fork 614
Open
Labels
area/clusterloaderlifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Description
We're accumulating a lot of code duplication for different types:
- pods:
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/util/pods.go
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/wait_for_pods.go - pvcs
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/util/pvcs.go
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/wait_for_pvcs.go - pvs
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/util/pvs.go
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/wait_for_pvs.go
Those should be refactor to share as much code as possible
Metadata
Metadata
Assignees
Labels
area/clusterloaderlifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.