fixed the container runtime documentation #48398

thisisharrsh · 2024-10-17T05:22:14Z

k8s-ci-robot · 2024-10-17T05:22:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/docs/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2024-10-17T05:31:22Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`fe88f18`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/671b6342f7850600085bbbe1
😎 Deploy Preview	https://deploy-preview-48398--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thisisharrsh · 2024-10-17T05:58:16Z

Deployment Preview: https://deploy-preview-48398--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/container-runtimes/#cri-versions

https://deploy-preview-48398--kubernetes-io-main-staging.netlify.app/docs/concepts/architecture/cri/#what-s-next

content/en/docs/concepts/architecture/cri.md

SergeyKanzhelev · 2024-10-17T06:14:51Z

content/en/docs/setup/production-environment/container-runtimes.md

@@ -171,7 +171,7 @@ follow [configuring a cgroup driver](/docs/tasks/administer-cluster/kubeadm/conf

 ## CRI version support {#cri-versions}

-Your container runtime must support at least v1alpha2 of the container runtime interface.
+Your container runtime must support at least v1 of the container runtime interface.


Suggested change

Your container runtime must support at least v1 of the container runtime interface.

Your container runtime must support v1 of the container runtime interface.

Noted! will apply those chnages.

content/en/docs/concepts/architecture/cri.md

content/en/docs/setup/production-environment/container-runtimes.md

…he reference for CRI proto

thisisharrsh · 2024-10-24T06:00:46Z

I have made the suggested changes, PTAL.

SergeyKanzhelev · 2024-10-24T06:53:06Z

Please address this comment as well: #48398 (comment)

thisisharrsh · 2024-10-24T07:27:01Z

Please address this comment as well: #48398 (comment)

website/content/en/docs/concepts/architecture/cri.md

Lines 34 to 35 in 251a596

    
           The v{{< skew currentVersion >}} kubelet can also negotiate CRI `v1alpha2`, but 
        
           this version is considered as deprecated.

I am changing the doc here as considered as deprecated and removed.
WDYT?

SergeyKanzhelev · 2024-10-24T18:47:05Z

This statement is invalid and need to be changed to simply say that no other versions are supported by the kubelet now:

website/content/en/docs/concepts/architecture/cri.md

Lines 31 to 33 in 251a596

    
           For Kubernetes v{{< skew currentVersion >}}, the kubelet prefers to use CRI `v1`. 
        
           If a container runtime does not support `v1` of the CRI, then the kubelet tries to 
        
           negotiate any older supported version.

thisisharrsh · 2024-10-25T09:27:02Z

Incorporated the suggested changes.
PTAL

thisisharrsh · 2024-10-25T09:32:13Z

Deployment Preview for the API part :: https://deploy-preview-48398--kubernetes-io-main-staging.netlify.app/docs/concepts/architecture/cri/#api

SergeyKanzhelev · 2024-10-25T16:24:40Z

content/en/docs/concepts/architecture/cri.md

 For Kubernetes v{{< skew currentVersion >}}, the kubelet prefers to use CRI `v1`.
-If a container runtime does not support `v1` of the CRI, then the kubelet tries to
-negotiate any older supported version.
-The v{{< skew currentVersion >}} kubelet can also negotiate CRI `v1alpha2`, but
-this version is considered as deprecated.
-If the kubelet cannot negotiate a supported CRI version, the kubelet gives up
-and doesn't register as a node.
+If a container runtime does not support `v1` of the CRI, then the kubelet cannot register as a node.
+The v{{< skew currentVersion >}} kubelet only supports CRI `v1`. The deprecated `v1alpha2` API is no longer supported. If the kubelet cannot connect to a container runtime using CRI `v1`, it will give up and will not register as a node.


now these two paragraphs are saying the same thing twice. Also instead of saying "kubelet gives up" please clarify. I think it still registers the node. It just never removes the Not Ready status.

Hi @SergeyKanzhelev, It would be great if you could suggest a possible change in the documentation. So that i can directly push those changes.

This is basically the task - review docs and update them. Sorry, I only have time to review changes and give a quick feedback. Maybe after code freeze I can find more time.

no problem!
I'll do the needful.

sftim · 2024-12-12T14:52:27Z

@thisisharrsh - would you like to update the PR to incorporate pending feedback?

k8s-triage-robot · 2025-03-12T14:59:04Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-04-11T15:51:35Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-05-11T16:45:23Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-05-11T16:45:29Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fixed the container runtime documentation

60c9f16

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2024

k8s-ci-robot requested review from bart0sh and vincepri October 17, 2024 05:22

k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2024

fixed the CRI proto reference

dbf8bc0

thisisharrsh marked this pull request as ready for review October 17, 2024 05:33

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024

k8s-ci-robot requested a review from reylejano October 17, 2024 05:33

thisisharrsh mentioned this pull request Oct 17, 2024

CRI API reference at Container Runtime page is stale #48257

Open

SergeyKanzhelev reviewed Oct 17, 2024

View reviewed changes

content/en/docs/concepts/architecture/cri.md Outdated Show resolved Hide resolved

SergeyKanzhelev reviewed Oct 17, 2024

View reviewed changes

content/en/docs/concepts/architecture/cri.md Outdated Show resolved Hide resolved

SergeyKanzhelev reviewed Oct 17, 2024

View reviewed changes

content/en/docs/setup/production-environment/container-runtimes.md Show resolved Hide resolved

fixed the suggested changes in the container runtime docs and fixed t…

c800db1

…he reference for CRI proto

Fixed the stale CRI documentation

fe88f18

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2024

SergeyKanzhelev reviewed Oct 25, 2024

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 11, 2025

k8s-ci-robot closed this May 11, 2025

	Your container runtime must support at least v1 of the container runtime interface.
	Your container runtime must support v1 of the container runtime interface.

fixed the container runtime documentation #48398

fixed the container runtime documentation #48398

Conversation

thisisharrsh commented Oct 17, 2024

Uh oh!

k8s-ci-robot commented Oct 17, 2024

Uh oh!

netlify bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

thisisharrsh commented Oct 17, 2024

Uh oh!

Uh oh!

SergeyKanzhelev Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

thisisharrsh Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thisisharrsh commented Oct 24, 2024

Uh oh!

SergeyKanzhelev commented Oct 24, 2024

Uh oh!

thisisharrsh commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SergeyKanzhelev commented Oct 24, 2024

Uh oh!

thisisharrsh commented Oct 25, 2024

Uh oh!

thisisharrsh commented Oct 25, 2024

Uh oh!

SergeyKanzhelev Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

thisisharrsh Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

SergeyKanzhelev Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

thisisharrsh Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

sftim commented Dec 12, 2024

Uh oh!

k8s-triage-robot commented Mar 12, 2025

Uh oh!

k8s-triage-robot commented Apr 11, 2025

Uh oh!

k8s-triage-robot commented May 11, 2025

Uh oh!

k8s-ci-robot commented May 11, 2025

Uh oh!

Uh oh!

netlify bot commented Oct 17, 2024 •

edited

Loading

thisisharrsh commented Oct 24, 2024 •

edited

Loading