Register some audit annotations #47451

Ritikaa96 · 2024-08-12T06:05:08Z

adding annotation:

apiserver.latency.k8s.io/etcd,
apiserver.latency.k8s.io/decode-response-object,
apiserver.latency.k8s.io/apf-queue-wait
Also corrected the description of annotation : k8s.io/removed-release
In the page Audit Annotations

Partially fixes: #29479

Ritikaa96 · 2024-08-12T06:05:30Z

/kind feature
/sig auth
/sig docs

Ritikaa96 · 2024-08-12T06:10:17Z

JFYI : annotation apiserver.latency.k8s.io/apf-queue-wait
was added in k/k repository in this release cycle only. If not required right now , i can remove it.
Ref: kubernetes/kubernetes#123919

netlify · 2024-08-12T06:13:16Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`36e798b`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679bba82f97c540008cbabc4
😎 Deploy Preview	https://deploy-preview-47451--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aramase · 2024-08-12T16:19:36Z

/sig api-machinery
/remove-sig auth

Ritikaa96 · 2024-09-12T10:03:47Z

@sftim @katcosgrove PTAL

sftim · 2024-09-25T03:50:28Z

/retitle Register some audit annotations

sftim

Thanks. I have some comments and suggestions.

Sorry it took a while; we're short on reviewers.

sftim · 2024-09-25T03:50:50Z

content/en/docs/reference/labels-annotations-taints/audit-annotations.md

@@ -31,7 +31,7 @@ request used a deprecated API version.

 Example: `k8s.io/removed-release: "1.22"`

-Value **must** be in the format "<major>.<minor>". It is set to target the removal release
+Value **must** be in the format "\<MAJOR>\.\<MINOR>\". It is set to target the removal release


Why this change?

When i tested the page . there was blank spaces instead of "." that's why

sftim · 2024-09-25T03:51:51Z

content/en/docs/reference/labels-annotations-taints/audit-annotations.md

+
+Example: `apiserver.latency.k8s.io/decode-response-object: "450.6649ns"`
+
+This annotation records the decoding time of response object.


This annotation records the time taken to … (what goes here)?

This annotation records the time taken to decode the response object.

Is it one of these?

Suggested change

This annotation records the decoding time of response object.

This annotation records the time taken to decode the response received from the storage layer (etcd).

Suggested change

This annotation records the decoding time of response object.

This annotation records the time that elapses whilst the API server is decoding the response that

it is about to send.

?

It's the time taken for both in a way .
For reference : https://github.com/tnorlin/kubernetes/blob/851cf43a35862aeeafc4a0966f7d1e0836f675e4/staging/src/k8s.io/apiserver/pkg/endpoints/request/webhook_duration.go#L156

This is latency incurred inside the function that takes an object returned from the underlying storage layer (etcd) and performs decoding of the response object.

content/en/docs/reference/labels-annotations-taints/audit-annotations.md

Ritikaa96 · 2024-09-25T04:35:41Z

Thanks. I have some comments and suggestions.

Sorry it took a while; we're short on reviewers.

No worries, I will wait for further comments on other raised PRs as well. there are more like this still waiting for reviews

content/en/docs/reference/labels-annotations-taints/audit-annotations.md

k8s-triage-robot · 2025-01-28T12:10:49Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Ritikaa96 · 2025-01-30T06:49:39Z

I might have missed this one, working on it currently , will update by tomorrow morning.
/remove-lifecycle stale

…8s.io/decode-response-object, apiserver.latency.k8s.io/apf-queue-wait Signed-off-by: Ritikaa96 <[email protected]>

Signed-off-by: Ritikaa96 <[email protected]>

Ritikaa96 · 2025-01-30T17:46:28Z

@katcosgrove @sftim PTAL

Ritikaa96 · 2025-03-26T12:35:18Z

Just a reminder: @sftim @katcosgrove @aramase
@ptal

sftim

/lgtm

sftim · 2025-03-26T12:39:04Z

content/en/docs/reference/labels-annotations-taints/audit-annotations.md

+
+Example: `apiserver.latency.k8s.io/etcd: "4.730661757s"`
+
+This annotation indiactes the measure of latency incurred inside the storage layer,


Suggested change

This annotation indiactes the measure of latency incurred inside the storage layer,

This annotation indicates the measure of latency incurred inside the storage layer,

Minor nit - can be fixed in a follow-up PR. Or if @Ritikaa96 , you're willing to push the changes within this week - happy to get this merged ASAP.

k8s-ci-robot · 2025-03-26T12:39:43Z

LGTM label has been added.

Git tree hash: 34454e15eba3b740c8dd68bc017f354ba02980a7

divya-mohan0209 · 2025-04-17T01:42:37Z

@kubernetes/sig-auth-pr-reviews PTAL and advise if this is technically accurate?

reylejano · 2025-05-13T17:49:38Z

See https://github.com/kubernetes/kubernetes/blob/c96032addd81199453a815c85370d8930b2f1cd3/staging/src/k8s.io/apiserver/pkg/endpoints/request/webhook_duration.go#L300
/approve

k8s-ci-robot · 2025-05-13T17:49:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested a review from katcosgrove August 12, 2024 06:05

k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2024

k8s-ci-robot requested a review from sftim August 12, 2024 06:05

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2024

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 12, 2024

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Aug 12, 2024

johnnyboystar22 mentioned this pull request Aug 12, 2024

Rad54s kubernetes #47464

Closed

k8s-ci-robot changed the title ~~Regsitering Audit annotations~~ Register some audit annotations Sep 25, 2024

sftim reviewed Sep 25, 2024

View reviewed changes

sftim reviewed Oct 29, 2024

View reviewed changes

content/en/docs/reference/labels-annotations-taints/audit-annotations.md Outdated Show resolved Hide resolved

sftim reviewed Oct 29, 2024

View reviewed changes

content/en/docs/reference/labels-annotations-taints/audit-annotations.md Outdated Show resolved Hide resolved

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2025

Ritikaa96 added 2 commits January 30, 2025 22:57

adding annotation: apiserver.latency.k8s.io/etcd, apiserver.latency.k…

f83013d

…8s.io/decode-response-object, apiserver.latency.k8s.io/apf-queue-wait Signed-off-by: Ritikaa96 <[email protected]>

edited as per Reviews

36e798b

Signed-off-by: Ritikaa96 <[email protected]>

Ritikaa96 force-pushed the audit-annotation-etcd-decode-latency branch from ad38d4f to 36e798b Compare January 30, 2025 17:44

sftim reviewed Mar 26, 2025

View reviewed changes

k8s-ci-robot assigned sftim Mar 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025

k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Apr 17, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025

k8s-ci-robot merged commit 99b9082 into kubernetes:main May 13, 2025
6 checks passed

github-project-automation bot moved this from !SIG Auth to Closed / Done in SIG Auth May 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Register some audit annotations #47451

Register some audit annotations #47451

Ritikaa96 commented Aug 12, 2024

Ritikaa96 commented Aug 12, 2024

Ritikaa96 commented Aug 12, 2024

netlify bot commented Aug 12, 2024 •

edited

Loading

aramase commented Aug 12, 2024

Ritikaa96 commented Sep 12, 2024

sftim commented Sep 25, 2024

sftim left a comment

sftim Sep 25, 2024

Ritikaa96 Sep 25, 2024

sftim Sep 25, 2024

Ritikaa96 Sep 25, 2024

sftim Sep 25, 2024

Ritikaa96 Oct 11, 2024 •

edited

Loading

Ritikaa96 Oct 11, 2024 •

edited

Loading

Ritikaa96 commented Sep 25, 2024 •

edited

Loading

k8s-triage-robot commented Jan 28, 2025

Ritikaa96 commented Jan 30, 2025

Ritikaa96 commented Jan 30, 2025

Ritikaa96 commented Mar 26, 2025

sftim left a comment

sftim Mar 26, 2025

divya-mohan0209 Apr 16, 2025

k8s-ci-robot commented Mar 26, 2025

divya-mohan0209 commented Apr 17, 2025

reylejano commented May 13, 2025

k8s-ci-robot commented May 13, 2025


		Example: `apiserver.latency.k8s.io/decode-response-object: "450.6649ns"`

		This annotation records the decoding time of response object.

	This annotation records the decoding time of response object.
	This annotation records the time that elapses whilst the API server is decoding the response that
	it is about to send.


		Example: `apiserver.latency.k8s.io/etcd: "4.730661757s"`

		This annotation indiactes the measure of latency incurred inside the storage layer,

	This annotation indiactes the measure of latency incurred inside the storage layer,
	This annotation indicates the measure of latency incurred inside the storage layer,

Register some audit annotations #47451

Register some audit annotations #47451

Conversation

Ritikaa96 commented Aug 12, 2024

Ritikaa96 commented Aug 12, 2024

Ritikaa96 commented Aug 12, 2024

netlify bot commented Aug 12, 2024 • edited Loading

✅ Pull request preview available for checking

aramase commented Aug 12, 2024

Ritikaa96 commented Sep 12, 2024

sftim commented Sep 25, 2024

sftim left a comment

Choose a reason for hiding this comment

sftim Sep 25, 2024

Choose a reason for hiding this comment

Ritikaa96 Sep 25, 2024

Choose a reason for hiding this comment

sftim Sep 25, 2024

Choose a reason for hiding this comment

Ritikaa96 Sep 25, 2024

Choose a reason for hiding this comment

sftim Sep 25, 2024

Choose a reason for hiding this comment

Ritikaa96 Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

Ritikaa96 Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

Ritikaa96 commented Sep 25, 2024 • edited Loading

k8s-triage-robot commented Jan 28, 2025

Ritikaa96 commented Jan 30, 2025

Ritikaa96 commented Jan 30, 2025

Ritikaa96 commented Mar 26, 2025

sftim left a comment

Choose a reason for hiding this comment

sftim Mar 26, 2025

Choose a reason for hiding this comment

divya-mohan0209 Apr 16, 2025

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 26, 2025

divya-mohan0209 commented Apr 17, 2025

reylejano commented May 13, 2025

k8s-ci-robot commented May 13, 2025

netlify bot commented Aug 12, 2024 •

edited

Loading

Ritikaa96 Oct 11, 2024 •

edited

Loading

Ritikaa96 Oct 11, 2024 •

edited

Loading

Ritikaa96 commented Sep 25, 2024 •

edited

Loading