Pushes to docker.io are using Pipeline name instead of registry username specified in pipeline settings

[drashy]

When Kubero attempts to push an image to a repo it uses the pipeline-name rather than the pre-configured registry-username so it ends up trying to push to a registry that does not exist and/or it has no access to.

Issue(s) occurs on these line(s) I believe: (of course I could be wrong)

kubero/server/src/modules/deployments.ts

Line 239 in 7d62716

image: process.env.KUBERO_BUILD_REGISTRY + "/" + pipeline + "/" + app,

kubero/server/src/kubero.ts

Line 1451 in 7d62716

image: `${process.env.KUBERO_BUILD_REGISTRY}/${pipeline}/${appName}`,

[drashy]

Also, I question whether it should be using process.env.KUBERO_BUILD_REGISTRY at all, shouldn't this use the registry settings in the pipeline or is the env var populated from the pipeline settings?

[mms-gianni]

Thank you for raising this bug.

I think i should refactor this in general a bit.