Merge pull request #283 from kubescape/panic

catch error on event casting in cooldownqueue

Author: matthyx

watcher/cooldownqueue.go

@@ -1,6 +1,7 @@
 package watcher
 
 import (
+	"errors"
 	"strings"
 	"sync"
 	"time"
@@ -52,10 +53,13 @@ func NewCooldownQueueWithParams(expiration, interval time.Duration) *CooldownQue
 }
 
 // makeEventKey creates a unique key for an event from a watcher
-func makeEventKey(e watch.Event) string {
+func makeEventKey(e watch.Event) (string, error) {
 	gvk := e.Object.GetObjectKind().GroupVersionKind()
-	meta := e.Object.(metav1.Object)
-	return strings.Join([]string{gvk.Group, gvk.Version, gvk.Kind, meta.GetNamespace(), meta.GetName()}, "/")
+	meta, ok := e.Object.(metav1.Object)
+	if !ok {
+		return "", errors.New("object does not implement metav1.Object")
+	}
+	return strings.Join([]string{gvk.Group, gvk.Version, gvk.Kind, meta.GetNamespace(), meta.GetName()}, "/"), nil
 }
 
 func (q *CooldownQueue) Closed() bool {
@@ -71,7 +75,10 @@ func (q *CooldownQueue) Enqueue(e watch.Event) {
 	if q.closed {
 		return
 	}
-	eventKey := makeEventKey(e)
+	eventKey, err := makeEventKey(e)
+	if err != nil {
+		return
+	}
 	q.seenEvents.Set(eventKey, e)
 }
 

watcher/cooldownqueue_test.go

@@ -91,7 +91,8 @@ func Test_makeEventKey(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got := makeEventKey(tt.e)
+			got, err := makeEventKey(tt.e)
+			assert.NoError(t, err)
 			assert.Equal(t, tt.want, got)
 		})
 	}