Adding fixed rule

Signed-off-by: Amit Schendel <[email protected]>

Author: amitschendel

rules/unauthenticated-service/raw.rego

@@ -1,21 +1,17 @@
 package armo_builtins
 
 deny[msga] {
-
     service := input[_]
     service.kind == "Service"
 
-    service_name := service.metadata.name
-
-    # Get the index and port
-    port := service.spec.ports[i]
+    hasUnauthenticatedService(service)
 
-    networkscanner.isUnauthenticatedService(service_name, port.port)
-
-    path := sprintf("spec.ports[%v].port", i)
+    service_name := service.metadata.name
+    
+    path := "spec.ports"
 
 	msga := {
-		"alertMessage": sprintf("service is unauthenticated: %s in port %v", service_name, port.port),
+		"alertMessage": sprintf("Unauthenticated service %v", service_name),
 		"alertScore": 7,
 		"fixPaths": [],
 		"reviewPaths": [path],
@@ -25,4 +21,13 @@ deny[msga] {
 			"k8sApiObjects": [service]
 		},
 	}
+}
+
+hasUnauthenticatedService(service) {
+    service.kind == "Service"
+    service_name := service.metadata.name
+    # Get the index and port
+    port := service.spec.ports[]
+
+    networkscanner.isUnauthenticatedService(service_name, port.port)
 }