Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Conversation

@the-fine
Copy link

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@nicufk nicufk changed the title scrape junit report fix: scrape junit report Aug 26, 2022
Copy link
Contributor

@nicufk nicufk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit to me. have you tested it out?

}

junitReportPath := filepath.Join(path, "results/junit.xml")
junitReportPath := filepath.Join(path, "reports/report.xml")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why file name changed ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants