🐛 fix: remove duplicate HandleK8sError/ClusterError from mcp_handler.go

These are now defined in k8s_errors.go and shared_types.go respectively.
Fixes Go compilation error: redeclared in this block.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: clubanderson

pkg/api/handlers/mcp_handler.go

@@ -2,7 +2,6 @@ package handlers
 
 import (
 	"context"
-	"errors"
 	"log/slog"
 	"sync"
 	"time"
@@ -59,68 +58,6 @@ func waitWithDeadline(wg *sync.WaitGroup, cancel context.CancelFunc, deadline ti
 	return WaitWithDeadline(wg, cancel, deadline)
 }
 
-// sanitizedErrorMessages maps error types to user-friendly messages that do
-// not expose internal infrastructure details (#4753).
-var sanitizedErrorMessages = map[string]string{
-	"network":     "Cluster is unreachable — check network connectivity",
-	"auth":        "Authentication to cluster failed — check credentials",
-	"timeout":     "Cluster request timed out — the cluster may be overloaded or unreachable",
-	"certificate": "TLS certificate error — check cluster certificate configuration",
-}
-
-// handleK8sError inspects a Kubernetes API error and returns the appropriate
-// HTTP response. Cluster-connectivity errors (network, auth, timeout,
-// certificate) are returned as 200 with a "clusterStatus":"unavailable"
-// payload so the frontend can show a degraded state instead of a broken page.
-// All other errors are returned as 500 Internal Server Error.
-// Raw error details are only logged server-side and never sent to the client (#4753).
-func HandleK8sError(c *fiber.Ctx, err error) error {
-	if errors.Is(err, k8s.ErrNoClusterConfigured) {
-		slog.Info("[MCP] no cluster configured")
-		return ErrNoClusterAccess(c)
-	}
-
-	errType := k8s.ClassifyError(err.Error())
-	switch errType {
-	case "not_found":
-		// Invalid or non-existent cluster — return 404 with consistent error format (#4907, #4908)
-		slog.Info("[MCP] cluster not found", "errorType", errType, "error", err)
-		return c.Status(fiber.StatusNotFound).JSON(fiber.Map{
-			"clusterStatus": "not_found",
-			"errorType":     errType,
-			"errorMessage":  "Cluster not found — verify the cluster name exists in your kubeconfig",
-		})
-	case "network", "auth", "timeout", "certificate":
-		// Cluster exists but is unreachable — return 503 with consistent error format (#4908)
-		slog.Info("[MCP] cluster unavailable", "errorType", errType, "error", err)
-		return c.Status(fiber.StatusServiceUnavailable).JSON(fiber.Map{
-			"clusterStatus": "unavailable",
-			"errorType":     errType,
-			"errorMessage":  sanitizedErrorMessages[errType],
-		})
-	default:
-		slog.Error("[MCP] internal error", "error", err)
-		return c.Status(fiber.StatusInternalServerError).JSON(fiber.Map{
-			"clusterStatus": "error",
-			"errorType":     "internal",
-			"errorMessage":  "An internal error occurred",
-		})
-	}
-}
-
-func handleK8sError(c *fiber.Ctx, err error) error {
-	return HandleK8sError(c, err)
-}
-
-// ClusterError represents a per-cluster failure in a multi-cluster request (#4758).
-// Included in the response so the frontend can distinguish "no resources" from
-// "cluster failed" and display an appropriate degraded-state indicator.
-type ClusterError struct {
-	Cluster   string `json:"cluster"`
-	ErrorType string `json:"errorType"`
-	Message   string `json:"message"`
-}
-
 // clusterErrorTracker collects per-cluster failures during multi-cluster
 // fan-out operations. Thread-safe via its own mutex.
 type clusterErrorTracker struct {
@@ -130,7 +67,7 @@ type clusterErrorTracker struct {
 
 func (t *clusterErrorTracker) add(cluster string, err error) {
 	errType := k8s.ClassifyError(err.Error())
-	msg, ok := sanitizedErrorMessages[errType]
+	msg, ok := SanitizedErrorMessages[errType]
 	if !ok {
 		msg = "An internal error occurred"
 	}