[scanner] 🐛 fix: repair 20 test failures — remove empty stubs and fix stale selectors (#19270)

* [scanner] fix: update ClusterCardList test selectors

- Change refresh button selector from /refreshClusterData/ to /common.refresh/
- Use getAllByText for multiple '-' elements during loading state

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: update PodDrillDown test selectors to match aria-labels

- Change namespace button selector from /drilldown.fields.namespace/ to /View namespace ns1/
- Change cluster button selector from /drilldown.fields.cluster/ to /View cluster c1/

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub files (1/4)

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - useUniversalStats.hook

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - useSnoozeHooks

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - useTokenUsage

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - useUniversalStats

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - shared-coverage

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - storage

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - kagent_crds

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - kagenti

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - networking

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - kubectlProxy.additional.edge

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - kubectlProxy.core.resources

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - cache-coverage

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - worker

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - AlertsContext.core

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [scanner] fix: remove empty test stub - AlertsContext.wave2

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: clubanderson

web/src/components/clusters/components/__tests__/ClusterCardList.test.tsx

@@ -99,7 +99,7 @@ describe('ClusterCardList', () => {
   it('calls onRefreshCluster when refresh button is clicked', () => {
     const onRefreshCluster = vi.fn()
     render(<ClusterCardList {...defaultProps} onRefreshCluster={onRefreshCluster} />)
-    const refreshButton = screen.getByRole('button', { name: /refreshClusterData/i })
+    const refreshButton = screen.getByRole('button', { name: /common\.refresh/i })
     fireEvent.click(refreshButton)
     expect(onRefreshCluster).toHaveBeenCalledTimes(1)
   })
@@ -108,7 +108,7 @@ describe('ClusterCardList', () => {
     const cluster = createMockCluster({ healthy: false, reachable: false })
     const onRefreshCluster = vi.fn()
     render(<ClusterCardList {...defaultProps} cluster={cluster} onRefreshCluster={onRefreshCluster} />)
-    const refreshButton = screen.getByRole('button', { name: /cluster.controlsDisabledOffline/i })
+    const refreshButton = screen.getByRole('button', { name: /cluster\.controlsDisabledOffline/i })
     expect(refreshButton).toBeDisabled()
   })
 
@@ -138,7 +138,7 @@ describe('ClusterCardList', () => {
       loading: true,
     })
     render(<ClusterCardList {...defaultProps} cluster={cluster} />)
-    // Loading indicator should be present
-    expect(screen.queryByText('-')).toBeInTheDocument()
+    // Loading indicator should be present — multiple fields show '-'
+    expect(screen.getAllByText('-').length).toBeGreaterThanOrEqual(1)
   })
 })

web/src/components/drilldown/views/__tests__/PodDrillDown.test.tsx

@@ -391,12 +391,12 @@ metadata:
     expect(screen.getByText('drilldown.fields.cluster')).toBeInTheDocument()
 
     // Namespace navigation
-    const nsBtn = screen.getByRole('button', { name: /drilldown.fields.namespace/ })
+    const nsBtn = screen.getByRole('button', { name: /View namespace ns1/ })
     await userEvent.click(nsBtn)
     expect(mockDrillToNamespace).toHaveBeenCalledWith('c1', 'ns1')
 
     // Cluster navigation
-    const clusterBtn = screen.getByRole('button', { name: /drilldown.fields.cluster/ })
+    const clusterBtn = screen.getByRole('button', { name: /View cluster c1/ })
     await userEvent.click(clusterBtn)
     expect(mockDrillToCluster).toHaveBeenCalledWith('c1')
   })