Merge branch 'main' into fix/govet-store-import

Author: clubanderson

.github/workflows/pr-verifier.yml

@@ -12,7 +12,7 @@ jobs:
   build-gate:
     name: build-gate
     runs-on: ubuntu-latest
-    timeout-minutes: 10
+    timeout-minutes: 15
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/pre-merge-gate.yml

@@ -13,11 +13,21 @@ import (
 	"github.com/kubestellar/console/pkg/safego"
 )
 
+// bridgeClient is the interface that MCP clients must satisfy for use in Bridge.
+// It is defined here (not in client.go) to keep Bridge testable: tests inject
+// mock implementations without spinning up real stdio processes.
+type bridgeClient interface {
+	CallTool(ctx context.Context, name string, args map[string]interface{}) (*CallToolResult, error)
+	Tools() []Tool
+	Stop() error
+	IsReady() bool
+}
+
 // Bridge manages MCP client connections and provides a unified interface
 type Bridge struct {
-	opsClient    *Client
-	deployClient *Client
-	gadgetClient *Client
+	opsClient    bridgeClient
+	deployClient bridgeClient
+	gadgetClient bridgeClient
 	mu           sync.RWMutex
 	config       BridgeConfig
 }
@@ -489,8 +499,6 @@ func (b *Bridge) CallDeployTool(ctx context.Context, name string, args map[strin
 	return client.CallTool(ctx, name, args)
 }
 
-
-
 // Status returns the current status of the MCP bridge
 func (b *Bridge) Status() map[string]interface{} {
 	b.mu.RLock()

pkg/mcp/bridge.go

@@ -555,7 +555,7 @@ func TestBridge_GetPods(t *testing.T) {
 				}
 				return tc.mockResponse, nil
 			})
-			bridge.opsClient = mockOps.Client
+			bridge.opsClient = mockOps
 
 			pods, err := bridge.GetPods(context.Background(), tc.cluster, tc.namespace, tc.labelSelector)
 
@@ -648,7 +648,7 @@ func TestBridge_FindPodIssues(t *testing.T) {
 				}
 				return tc.mockResponse, nil
 			})
-			bridge.opsClient = mockOps.Client
+			bridge.opsClient = mockOps
 
 			issues, err := bridge.FindPodIssues(context.Background(), tc.cluster, tc.namespace)
 
@@ -734,7 +734,7 @@ func TestBridge_GetEvents(t *testing.T) {
 				}
 				return tc.mockResponse, nil
 			})
-			bridge.opsClient = mockOps.Client
+			bridge.opsClient = mockOps
 
 			events, err := bridge.GetEvents(context.Background(), tc.cluster, tc.namespace, tc.limit)
 
@@ -819,7 +819,7 @@ func TestBridge_GetWarningEvents(t *testing.T) {
 				}
 				return tc.mockResponse, nil
 			})
-			bridge.opsClient = mockOps.Client
+			bridge.opsClient = mockOps
 
 			events, err := bridge.GetWarningEvents(context.Background(), tc.cluster, tc.namespace, tc.limit)
 
@@ -905,7 +905,7 @@ func TestBridge_GetClusterHealth(t *testing.T) {
 				}
 				return tc.mockResponse, nil
 			})
-			bridge.opsClient = mockOps.Client
+			bridge.opsClient = mockOps
 
 			health, err := bridge.GetClusterHealth(context.Background(), tc.cluster)
 
@@ -974,7 +974,7 @@ func TestBridge_ListClusters(t *testing.T) {
 				}
 				return tc.mockResponse, nil
 			})
-			bridge.opsClient = mockOps.Client
+			bridge.opsClient = mockOps
 
 			clusters, err := bridge.ListClusters(context.Background())
 

pkg/mcp/bridge_test.go

@@ -333,6 +333,9 @@ func (c *Client) CallTool(ctx context.Context, name string, args map[string]inte
 		return nil, err
 	}
 
+	if result == nil {
+		return nil, fmt.Errorf("nil result from tools/call")
+	}
 	var toolResult CallToolResult
 	if err := json.Unmarshal(result, &toolResult); err != nil {
 		return nil, fmt.Errorf("failed to parse tool result: %w", err)
@@ -355,6 +358,9 @@ func (c *Client) initialize(ctx context.Context) error {
 		return err
 	}
 
+	if result == nil {
+		return fmt.Errorf("nil result from initialize")
+	}
 	var initResult InitializeResult
 	if err := json.Unmarshal(result, &initResult); err != nil {
 		return fmt.Errorf("failed to parse initialize result: %w", err)
@@ -375,6 +381,9 @@ func (c *Client) listTools(ctx context.Context) error {
 		return err
 	}
 
+	if result == nil {
+		return fmt.Errorf("nil result from tools/list")
+	}
 	var toolsResult ToolsListResult
 	if err := json.Unmarshal(result, &toolsResult); err != nil {
 		return fmt.Errorf("failed to parse tools list: %w", err)

pkg/mcp/client.go

@@ -68,6 +68,12 @@ describe('Login Component', () => {
     expect(screen.getByText('KubeStellar')).toBeInTheDocument()
   })
 
+  it('does not render a terms of service footer', () => {
+    renderLogin()
+    expect(screen.queryByText('login.termsOfServicePrefix')).not.toBeInTheDocument()
+    expect(screen.queryByText('login.termsOfServiceLink')).not.toBeInTheDocument()
+  })
+
   describe('OAuth setup wizard (backendUp && !oauthConfigured)', () => {
     beforeEach(() => {
       oauthProbeResult = { backendUp: true, oauthConfigured: false }

web/src/components/auth/Login.test.tsx

@@ -19,9 +19,6 @@ import { sanitizeUrl } from '@/lib/utils/sanitizeUrl'
 // The Suspense fallback (spinner) shows while loading.
 const GlobeAnimation = safeLazy(() => import('../animations/globe'), 'GlobeAnimation')
 
-// Apache 2.0 license is the project's effective terms; link opens in a new tab (#8376).
-const TERMS_OF_SERVICE_URL = 'https://github.com/kubestellar/console/blob/main/LICENSE'
-
 // GitHub Developer Settings URL for creating OAuth Apps.
 const GITHUB_DEVELOPER_SETTINGS_URL = 'https://github.com/settings/developers'
 
@@ -583,18 +580,6 @@ export function Login() {
             </div>
           )}
 
-          {/* Footer */}
-          <div className="text-center text-sm text-muted-foreground mt-8">
-            {t('login.termsOfServicePrefix')}{' '}
-            <a
-              href={TERMS_OF_SERVICE_URL}
-              target="_blank"
-              rel="noopener noreferrer"
-              className="underline hover:text-foreground transition-colors"
-            >
-              {t('login.termsOfServiceLink')}
-            </a>
-          </div>
         </div>
       </div>
 

web/src/components/auth/Login.tsx

@@ -38,11 +38,21 @@ export function ActionTooltipWrapper({
   tooltip: string
   children: ReactNode
 }) {
+  const handleKeyDown = (event: KeyboardEvent) => {
+    if (event.key === 'Enter' || event.key === ' ') {
+      event.preventDefault()
+      event.stopPropagation()
+    }
+  }
+
   return (
     <span
       className="inline-flex"
+      role="button"
+      tabIndex={0}
       onClick={(event) => event.stopPropagation()}
       onMouseDown={(event) => event.stopPropagation()}
+      onKeyDown={handleKeyDown}
     >
       <Tooltip content={tooltip}>{children}</Tooltip>
     </span>

web/src/components/clusters/components/ClusterGrid.common.tsx

@@ -169,7 +169,7 @@ export function HelmReleaseDrillDown({ data }: Props) {
     if (result.success) {
       // Refresh data after rollback
       fetchReleaseInfo()
-      fetchHistory()
+      fetchHistory(true)
     }
   }
 
@@ -228,8 +228,8 @@ export function HelmReleaseDrillDown({ data }: Props) {
   }
 
   // Fetch release history
-  const fetchHistory = async () => {
-    if (!agentConnected || releaseHistory) return
+  const fetchHistory = async (force = false) => {
+    if (!agentConnected || (releaseHistory && !force)) return
     setHistoryLoading(true)
     try {
       const output = await runHelm(['history', releaseName, '-n', namespace, '-o', 'json'])
@@ -252,8 +252,9 @@ export function HelmReleaseDrillDown({ data }: Props) {
       }
     } catch {
       setReleaseHistory([])
+    } finally {
+      setHistoryLoading(false)
     }
-    setHistoryLoading(false)
   }
 
   // Fetch release resources (manifest)

web/src/components/drilldown/views/HelmReleaseDrillDown.tsx

@@ -22,6 +22,7 @@ interface UsePodActionsProps {
   annotations: Record<string, string> | null
   ownerChain: RelatedResource[]
   openTrackedWs: () => Promise<WebSocket>
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- WS messages are untyped JSON
   parseWsMessage: (event: MessageEvent, context: string) => any
 }