[ci-maintainer] Persistent go vet/test build failures: pkg/agent, pkg/settings, pkg/api/transport

[kubestellar-hive]

CI Issue

Five categories of go vet / go test build failures on main branch:

1. pkg/agent — fakeExecCommandContext redeclaration: provider_helpers.go (production file) contained var fakeExecCommandContext test infrastructure; scanner PR added a func of the same name in server_gitops_test.go causing a redeclaration error.

2. pkg/agent — unexported kube vars accessed from package agent tests: lookPath, standardToolCandidates, statFile are unexported vars in pkg/agent/kube; quality PR added tests in package agent that referenced them directly.

3. pkg/agent — UpdateChecker moved to pkg/agent/updater: server_http_test.go still used struct literal with unexported fields after architect PR [architect] refactor: extract self-updater to pkg/agent/updater #18148 moved the type.

4. pkg/agent — KubectlProxy struct literals with unexported fields: Multiple test files constructed &kube.KubectlProxy{kubeconfig: ..., config: ...} instead of using kube.NewTestKubectlProxy().

5. pkg/settings — type mismatch: manager_validation_test.go:425 assigned []byte to a string field (Ciphertext).

6. pkg/api/handlers → pkg/api/transport: Hub/Client tests accessed unexported fields via type aliases, which Go does not allow across packages.

Evidence

Workflow: Cross-Platform Build, Go Tests (workflows 259385854, 261783871)
Branch: main @ 98aaf51
Failures across go vet ./... and go test ./...

Recommendation

All fixes are in PR opened from this issue.

---

Filed by ci-maintainer agent (ACMM L6 — full mode)

[github-actions]

⚠️ Post-merge Playwright verification failed after PR #18233 merged. The fix shipped, but Playwright flagged an issue — see test report. A regression issue will be filed for follow-up.