Add DNS-1123 validation for templated volume names

[coderabbitai]

Description

The setVolumeNameFromTemplate function generates volume names from templates but does not validate that the resulting names are valid DNS-1123 labels. This can lead to invalid Kubernetes resource names being used.

Context

Unlike setObjectNameFromTemplate (used for PVC naming) which includes DNS-1123 validation, the volume naming path lacks this validation step.

References

• Original discussion: MTV-3091 | Add pvc name template support to volume populator flows #2540 (comment)
• Related PR: MTV-3091 | Add pvc name template support to volume populator flows #2540
• Requested by: @yaacov

Location

File: pkg/controller/plan/adapter/vsphere/builder.go
Function: setVolumeNameFromTemplate