debug-flag

Signed-off-by: yaacov <yzamir@redhat.com>

Author: yaacov

README.md

@@ -99,6 +99,8 @@ uv run mtv-tui         # TUI only
 | Subcommand | Description |
 |------------|-------------|
 | *(default)* / `run [--resume ID]` | Start the server + TUI (optionally resume a saved session) |
+| `run --dump-http` | Dump LLM HTTP requests/responses to `~/.mtv-agent/dumps/` |
+| `run --dump-http-dir DIR` | Set dump directory (implies `--dump-http`) |
 | `init [--dir DIR] [--force]` | Bootstrap `~/.mtv-agent/` with config, skills, and commands |
 | `config` | Print default `config.json` to stdout |
 
@@ -129,7 +131,8 @@ Config files are searched in order: `./` (CWD) then `~/.mtv-agent/`.
   "skills":   { "dir": "~/.mtv-agent/skills" },
   "commands": { "dir": "~/.mtv-agent/commands" },
   "cache":    { "dir": "~/.mtv-agent/cache" },
-  "agent":    { "maxIterations": 20 }
+  "agent":    { "maxIterations": 20 },
+  "debug":    { "dumpHttp": false, "dumpHttpDir": "~/.mtv-agent/dumps" }
 }
 ```
 

mtv_agent/cli.py

@@ -92,7 +92,16 @@ def _cmd_run(args: argparse.Namespace) -> None:
             **os.environ,
             "MTV_AGENT_HOST": "127.0.0.1",
             "MTV_AGENT_PORT": str(args.port),
-            **({"MTV_AGENT_DUMP_HTTP": "1"} if args.dump_http else {}),
+            **(
+                {"MTV_AGENT_DUMP_HTTP": "1"}
+                if args.dump_http or args.dump_http_dir
+                else {}
+            ),
+            **(
+                {"MTV_AGENT_DUMP_HTTP_DIR": args.dump_http_dir}
+                if args.dump_http_dir
+                else {}
+            ),
         },
     )
 
@@ -184,6 +193,12 @@ def main():
         default=False,
         help="Dump LLM HTTP requests and responses to ~/.mtv-agent/dumps/",
     )
+    p_run.add_argument(
+        "--dump-http-dir",
+        metavar="DIR",
+        default=None,
+        help="Directory for HTTP dump files (implies --dump-http)",
+    )
     p_run.set_defaults(func=_cmd_run)
 
     # -- init ----------------------------------------------------------------

mtv_agent/server/app.py

@@ -77,7 +77,7 @@ async def lifespan(_app: FastAPI):
             _write_startup_error(msg)
             raise SystemExit(1) from None
 
-    dump_dir = str(Path(settings.dump_dir).expanduser()) if settings.dump_llm else None
+    dump_dir = str(Path(settings.dump_http_dir).expanduser()) if settings.dump_http else None
     llm = LLMClient(
         base_url=settings.llm_base_url,
         api_key=settings.llm_api_key,

mtv_agent/server/config.py

@@ -153,8 +153,8 @@ class Settings:
     max_iterations: int = 20
     max_history_chars: int = 160_000
     mcp_config: str | None = None
-    dump_llm: bool = False
-    dump_dir: str = "~/.mtv-agent/dumps"
+    dump_http: bool = False
+    dump_http_dir: str = "~/.mtv-agent/dumps"
 
 
 def load_settings(override: str | None = None) -> Settings:
@@ -179,10 +179,11 @@ def load_settings(override: str | None = None) -> Settings:
         cache_dir=cache.get("dir", Settings.cache_dir),
         max_iterations=agent.get("maxIterations", Settings.max_iterations),
         max_history_chars=agent.get("maxHistoryChars", Settings.max_history_chars),
-        dump_llm=os.environ.get("MTV_AGENT_DUMP_HTTP", "").strip().lower()
+        dump_http=os.environ.get("MTV_AGENT_DUMP_HTTP", "").strip().lower()
         in ("1", "true", "yes")
-        or debug.get("dumpLlm", Settings.dump_llm),
-        dump_dir=debug.get("dumpDir", Settings.dump_dir),
+        or debug.get("dumpHttp", Settings.dump_http),
+        dump_http_dir=os.environ.get("MTV_AGENT_DUMP_HTTP_DIR")
+        or debug.get("dumpHttpDir", Settings.dump_http_dir),
     )
 
 

mtv_agent/server/data/config.json.example

@@ -25,7 +25,7 @@
     "theme": "textual-dark"
   },
   "debug": {
-    "dumpLlm": false,
-    "dumpDir": "~/.mtv-agent/dumps"
+    "dumpHttp": false,
+    "dumpHttpDir": "~/.mtv-agent/dumps"
   }
 }

tests/test_config.py

@@ -61,6 +61,31 @@ def test_load_mcp_servers_from_file():
     assert stdio_srv.args == ["--flag"]
 
 
+def test_load_settings_dump_http_from_config():
+    data = {
+        "llm": {"baseUrl": "http://localhost:1234/v1"},
+        "debug": {"dumpHttp": True, "dumpHttpDir": "/tmp/my-dumps"},
+    }
+    with tempfile.NamedTemporaryFile(mode="w", suffix=".json", delete=False) as f:
+        json.dump(data, f)
+        f.flush()
+        s = load_settings(f.name)
+    assert s.dump_http is True
+    assert s.dump_http_dir == "/tmp/my-dumps"
+
+
+def test_load_settings_dump_http_dir_env_var(monkeypatch):
+    data = {"llm": {"baseUrl": "http://localhost:1234/v1"}}
+    monkeypatch.setenv("MTV_AGENT_DUMP_HTTP", "1")
+    monkeypatch.setenv("MTV_AGENT_DUMP_HTTP_DIR", "/tmp/env-dumps")
+    with tempfile.NamedTemporaryFile(mode="w", suffix=".json", delete=False) as f:
+        json.dump(data, f)
+        f.flush()
+        s = load_settings(f.name)
+    assert s.dump_http is True
+    assert s.dump_http_dir == "/tmp/env-dumps"
+
+
 def test_load_mcp_servers_missing_file():
     result = load_mcp_servers("/nonexistent/mcp.json")
     assert result == []