Skip to content

Commit 69e0edf

Browse files
committed
fix(workflowsteps): update password assignment in Notification step to use correct return value syntax
fix(traits): add workload reference path and conflict handling in K8sUpdateStrategy definition Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com>
1 parent 9196be9 commit 69e0edf

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

traits/k8s_update_strategy.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ func K8sUpdateStrategy() *defkit.TraitDefinition {
4242
return defkit.NewTrait("k8s-update-strategy").
4343
Description("Set k8s update strategy for Deployment/DaemonSet/StatefulSet").
4444
AppliesTo("deployments.apps", "statefulsets.apps", "daemonsets.apps").
45+
ConflictsWith().
4546
PodDisruptive(false).
47+
WorkloadRefPath("").
4648
Params(targetAPIVersion, targetKind, strategy).
4749
Template(func(tpl *defkit.Template) {
4850
// References to parameter fields

workflowsteps/notification.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ func Notification() *defkit.WorkflowStepDefinition {
316316
if parameter.email.from.alias != _|_ {
317317
alias: parameter.email.from.alias
318318
}
319-
password: stringValue.str
319+
password: stringValue.$returns.str
320320
host: parameter.email.from.host
321321
port: parameter.email.from.port
322322
}

0 commit comments

Comments
 (0)