ci(hot-cluster): fix IPI flavor format (bx2-4x16 not bx2.4x16)

openshift-install uses hyphen-separated VPC instance profiles (bx2-4x16)
while ibmcloud oc uses dot-separated (bx2.4x16). Convert automatically.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: galkremer1

.github/workflows/ibmc-cluster-setup.yml

@@ -306,6 +306,9 @@ jobs:
           ssh-keygen -t ed25519 -f "${INSTALL_DIR}/ssh-key" -N "" -q
           SSH_PUB=$(cat "${INSTALL_DIR}/ssh-key.pub")
 
+          # IPI uses hyphen-separated flavors (bx2-4x16), not dot (bx2.4x16)
+          IPI_WORKER_FLAVOR=$(echo "${WORKER_FLAVOR}" | sed 's/\./-/g')
+
           cat > "${INSTALL_DIR}/install-config.yaml" <<EOF
           apiVersion: v1
           metadata:
@@ -321,15 +324,15 @@ jobs:
             replicas: 3
             platform:
               ibmcloud:
-                type: bx2.4x16
+                type: bx2-4x16
           compute:
             - architecture: amd64
               hyperthreading: Enabled
               name: worker
               replicas: ${WORKER_COUNT}
               platform:
                 ibmcloud:
-                  type: ${WORKER_FLAVOR}
+                  type: ${IPI_WORKER_FLAVOR}
           networking:
             networkType: OVNKubernetes
             clusterNetwork: