Commit 0b95911
authored
makefile: Fix release target for Go 1.24 tool directive (#2522)
The Go 1.24 tool directive migration was intoroduced on former change
[0], but the release target had a shell parsing issue.
When GITHUB_RELEASE expands to "/path/to/go tool github-release"
(containing spaces) and is used as an inline environment variable:
GITHUB_RELEASE=$(GITHUB_RELEASE) TAG=... hack/release.sh
The shell parses it as:
GITHUB_RELEASE=/path/to/go (env var)
tool (command to execute - not found!)
Fixed by using export statements with quoted values instead of
inline environment variable assignments.
[0]
#2493
Signed-off-by: Ram Lavi <[email protected]>1 parent 9bc4457 commit 0b95911
1 file changed
+5
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
| |||
0 commit comments