Skip to content

Commit 0b95911

Browse files
authored
makefile: Fix release target for Go 1.24 tool directive (#2522)
The Go 1.24 tool directive migration was intoroduced on former change [0], but the release target had a shell parsing issue. When GITHUB_RELEASE expands to "/path/to/go tool github-release" (containing spaces) and is used as an inline environment variable: GITHUB_RELEASE=$(GITHUB_RELEASE) TAG=... hack/release.sh The shell parses it as: GITHUB_RELEASE=/path/to/go (env var) tool (command to execute - not found!) Fixed by using export statements with quoted values instead of inline environment variable assignments. [0] #2493 Signed-off-by: Ram Lavi <[email protected]>
1 parent 9bc4457 commit 0b95911

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,11 @@ release-notes:
220220
hack/render-release-notes.sh $(WHAT)
221221

222222
release: $(GO)
223-
GITHUB_RELEASE=$(GITHUB_RELEASE) \
224-
TAG=v$(shell hack/version.sh) \
225-
hack/release.sh \
226-
manifests/cluster-network-addons/cluster-network-addons.package.yaml \
227-
$(shell find manifests/cluster-network-addons/$(shell hack/version.sh) -type f)
223+
export GITHUB_RELEASE="$(GITHUB_RELEASE)"; \
224+
export TAG=v$(shell hack/version.sh); \
225+
hack/release.sh \
226+
manifests/cluster-network-addons/cluster-network-addons.package.yaml \
227+
$(shell find manifests/cluster-network-addons/$(shell hack/version.sh) -type f)
228228

229229
vendor: $(GO)
230230
$(GO) mod tidy -compat=$(GO_VERSION)

0 commit comments

Comments
 (0)