Skip to content

Commit a2ee97b

Browse files
committed
upgrade metrics-linter version
Signed-off-by: avlitman <alitman@redhat.com>
1 parent 6d01444 commit a2ee97b

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

hack/prom_metric_linter.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
set -e
2222

23-
linter_image_tag="v0.0.11"
23+
linter_image_tag="v0.0.12"
2424

2525
PROJECT_ROOT="$(readlink -e "$(dirname "${BASH_SOURCE[0]}")"/../)"
2626
export METRICS_COLLECTOR_PATH="${METRICS_COLLECTOR_PATH:-${PROJECT_ROOT}/tools/prom-metrics-collector}"

tools/prom-metrics-collector/metrics_json_generator.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,8 @@ import (
3232
)
3333

3434
// This should be used only for very rare cases where the naming conventions that are explained in the best practices:
35-
// https://sdk.operatorframework.io/docs/best-practices/observability-best-practices/#metrics-guidelines
36-
// should be ignored.
37-
var excludedMetrics = map[string]struct{}{
38-
"cluster:vmi_request_cpu_cores:sum": {},
39-
}
35+
// https://sdk.operatorframework.io/docs/best-practices/observability-best-practices/ should be ignored.
36+
var excludedMetrics = map[string]struct{}{}
4037

4138
type RecordingRule struct {
4239
Record string `json:"record,omitempty"`

0 commit comments

Comments
 (0)