-
Notifications
You must be signed in to change notification settings - Fork 186
push-test-metrics: hard coded periodic names #4802
Copy link
Copy link
Open
Labels
good first issueIdentifies an issue that has been specifically created or selected for first-time contributors.Identifies an issue that has been specifically created or selected for first-time contributors.help wantedIdentifies an issue that has been specifically created or selected for new contributors.Identifies an issue that has been specifically created or selected for new contributors.kind/bugpriority/backlogIndicate that the issue or PR is a lower priority and can be worked on in the futureIndicate that the issue or PR is a lower priority and can be worked on in the futuretriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Metadata
Metadata
Assignees
Labels
good first issueIdentifies an issue that has been specifically created or selected for first-time contributors.Identifies an issue that has been specifically created or selected for first-time contributors.help wantedIdentifies an issue that has been specifically created or selected for new contributors.Identifies an issue that has been specifically created or selected for new contributors.kind/bugpriority/backlogIndicate that the issue or PR is a lower priority and can be worked on in the futureIndicate that the issue or PR is a lower priority and can be worked on in the futuretriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
What happened:
Periodic names that are looked at are hard coded:
project-infra/robots/push-test-metrics/main.go
Line 57 in 16ce7a1
This generates test times from old job runs and ridicules the values.
What you expected to happen:
Job names should be deferred from the kubevirt-periodics.yaml
Use
project-infra/vendor/sigs.k8s.io/prow/pkg/config/config.go
Line 1678 in 1e74906
How to reproduce it (as minimally and precisely as possible):
See link, see k8s lane names in grafana panel: https://grafana.ci.kubevirt.io/d/gY4hNc5Iz/kubevirt-kubevirt-e2e-test-runtimes?orgId=1&editPanel=6
Additional context:
n/a
/help
/good-first-issue