Feature Request: Removing a Policy Server should not delete the policies scheduled on top of it

[flavio]

Is your feature request related to a problem?

Currently, when a PolicyServer resource is deleted, all the policies scheduled on top of it are deleted.

This can be surprising to an user and could cause data loss.

Solution you'd like

When a Policy Server is removed, all the policies scheduled on top of it should be left untouched. Their status should transition automatically to "pending" state.

Alternatives you've considered

No response

Anything else?

This is going to help when we will change our deployment from having 3 different helm charts to have a single one.

During the upgrade the user must delete the 3 helm charts installations and then install the new one. During this transition all the user policies are going to be removed from etcd, which is quite a disservice.

[flavio]

Moved to pending review so that we can discuss this change. If approved, we should attempt to implement that as part of the next release (1.36) to ensure everything is in place by the time we move to the single helm chart.

[jvanz]

From what I see in the git history, this is a very old behavior. I believe this is done to avoid race conditions when the policy server is gone and the policies web hooks are not deleted yet. Which make sense. But I agree that we could do better by moving the policies back to the "scheduled" state before delete the policy server resources.

[viccuad]

We agreed on the daily that this is worth to implement, moving to todo.