fix

fix

Signed-off-by: 张浩宇 <zhanghaoyu.zhy@bytedance.com>

Author: zhanghaoyu1986

pkg/agent/qrm-plugins/cpu/dynamicpolicy/irqtuner/controller/controller_linux_test.go

@@ -58,7 +58,7 @@ func Test_clearNicXPS(t *testing.T) {
 			},
 		}
 
-		PatchConvey("Scenario 1: Set XPS successfully", func() {
+		PatchConvey("Scenario 1: clear NIC XPS successfully", func() {
 			Mock(machine.GetNicTxQueuesXpsConf).Return(map[int]string{
 				0: "ffff",
 			}, nil).Build()
@@ -70,7 +70,19 @@ func Test_clearNicXPS(t *testing.T) {
 			So(err, ShouldBeNil)
 		})
 
-		PatchConvey("Scenario 2: GetNicTxQueuesXpsConf failed", func() {
+		PatchConvey("Scenario 2: IsZeroBitmap", func() {
+			Mock(machine.GetNicTxQueuesXpsConf).Return(map[int]string{
+				0: "ffff",
+			}, nil).Build()
+
+			Mock(machine.IsZeroBitmap).Return(true).Build()
+
+			err := ic.clearNicXPS(nic)
+
+			So(err, ShouldBeNil)
+		})
+
+		PatchConvey("Scenario 3: GetNicTxQueuesXpsConf failed", func() {
 			nic.QueueNum = 0
 			expectedErr := fmt.Errorf("invalid queue number %d", nic.QueueNum)
 
@@ -80,7 +92,7 @@ func Test_clearNicXPS(t *testing.T) {
 			So(err, ShouldResemble, expectedErr)
 		})
 
-		PatchConvey("Scenario 3: ClearNicTxQueueXPS failed", func() {
+		PatchConvey("Scenario 4: ClearNicTxQueueXPS failed", func() {
 			nic.QueueNum = 1
 			expectedErr := errors.New("failed to clear tx queue xps")
 
@@ -96,3 +108,86 @@ func Test_clearNicXPS(t *testing.T) {
 		})
 	})
 }
+
+func Test_clearRPSForNic(t *testing.T) {
+	t.Parallel()
+	PatchConvey("Test_clearRPSForNic", t, func() {
+		ic := &IrqTuningController{
+			Nics: []*NicIrqTuningManager{
+				{
+					NicInfo: &NicInfo{
+						NicBasicInfo: &machine.NicBasicInfo{
+							InterfaceInfo: machine.InterfaceInfo{
+								Name: "eth0",
+							},
+							Irq2Queue: map[int]int{
+								100: 0,
+							},
+							Queue2Irq: map[int]int{
+								0: 100,
+							},
+							QueueNum: 1,
+						},
+						Irq2Core: map[int]int64{
+							100: 2,
+						},
+						SocketIrqCores: map[int][]int64{
+							0: {2},
+						},
+					},
+				},
+			},
+		}
+
+		PatchConvey("Scenario 1: clear NIC RPS successfully", func() {
+			Mock(machine.GetNicRxQueuesRpsConf).Return(map[int]string{
+				0: "ffff",
+			}, nil).Build()
+
+			Mock(machine.ClearNicRxQueueRPS).Return(nil).Build()
+
+			err := ic.clearRPSForNic(ic.Nics[0])
+
+			So(err, ShouldBeNil)
+		})
+
+		PatchConvey("Scenario 2: IsZeroBitmap", func() {
+			Mock(machine.GetNicRxQueuesRpsConf).Return(map[int]string{
+				0: "ffff",
+			}, nil).Build()
+
+			Mock(machine.IsZeroBitmap).Return(true).Build()
+
+			err := ic.clearRPSForNic(ic.Nics[0])
+
+			So(err, ShouldBeNil)
+		})
+
+		PatchConvey("Scenario 3: ClearNicRxQueueRPS failed", func() {
+			nic := ic.Nics[0]
+			nic.NicInfo.QueueNum = 0
+			expectedErr := fmt.Errorf("invalid queue number %d", nic.NicInfo.QueueNum)
+
+			err := ic.clearRPSForNic(nic)
+
+			So(err, ShouldNotBeNil)
+			So(err, ShouldResemble, expectedErr)
+		})
+
+		PatchConvey("Scenario 4: ClearNicRxQueueRPS failed", func() {
+			nic := ic.Nics[0]
+			nic.NicInfo.QueueNum = 1
+			expectedErr := errors.New("failed to clear rx queue rps")
+
+			Mock(machine.GetNicTxQueuesXpsConf).Return(map[int]string{
+				0: "ffff",
+			}, nil).Build()
+
+			Mock(machine.ClearNicRxQueueRPS).Return(expectedErr).Build()
+
+			err := ic.clearRPSForNic(nic)
+
+			So(err, ShouldBeNil)
+		})
+	})
+}