Skip to content

Commit 39dd1d5

Browse files
authored
Merge pull request #1022 from JulyWindK/dev/kfx-fix-nil-point
fix(qrm): fix the null pointer issue in deletionOptions
2 parents 7eb5c42 + 02daffb commit 39dd1d5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pkg/agent/evictionmanager/eviction_resp_collector.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,16 +191,17 @@ func (e *evictionRespCollector) collectTopEvictionPods(dryRunPlugins []string, p
191191

192192
for _, pod := range targetPods {
193193
deletionOptions := resp.DeletionOptions
194+
if deletionOptions == nil {
195+
deletionOptions = &pluginapi.DeletionOptions{}
196+
}
194197
reason := fmt.Sprintf("plugin %s met threshold in scope %s, target %v, observed %v",
195198
pluginName, threshold.EvictionScope, threshold.ThresholdValue, threshold.ObservedValue)
196199

197200
forceEvictPod := e.getForceEvictPods()[string(pod.UID)]
198201
if forceEvictPod != nil && forceEvictPod.EvictPod != nil {
199-
if deletionOptions != nil && forceEvictPod.EvictPod.DeletionOptions != nil {
202+
if forceEvictPod.EvictPod.DeletionOptions != nil {
200203
deletionOptions.GracePeriodSeconds = general.MaxInt64(deletionOptions.GracePeriodSeconds,
201204
forceEvictPod.EvictPod.DeletionOptions.GracePeriodSeconds)
202-
} else if forceEvictPod.EvictPod.DeletionOptions != nil {
203-
deletionOptions.GracePeriodSeconds = forceEvictPod.EvictPod.DeletionOptions.GracePeriodSeconds
204205
}
205206
reason = fmt.Sprintf("%s; %s", reason, forceEvictPod.EvictPod.Reason)
206207
}

0 commit comments

Comments
 (0)