fix i18n

Author: kuboon

Gemfile

@@ -6,8 +6,7 @@ source "https://rubygems.org"
 gemspec
 
 group :development, :test do
-  gem "actionpack"
-  gem "bundler"
+  gem "actionpack", require: false
   gem "debug"
   gem "rake"
   gem "rspec"

config/locales/en.restful_error.yml

@@ -1,11 +1,12 @@
-ja:
+en:
   restful_error:
     active_record/record_not_found: Requested resource is not found
+    action_controller/routing_error: Requested resource is not found
     can_can/unauthorized: Unauthorized
     bad_request: Bad request #400
     unauthorized: Unauthorized #401
     forbidden: Forbidden #403
-    not_found: Not found #404
+    not_found: Page not found #404
     method_not_allowed: Requested HTTP Method is not allowd #405
     gone: Gone #410
     unprocessable_content: Content is readable but unprocessable #422

lib/restful_error.rb

@@ -5,25 +5,28 @@
 require "restful_error/status"
 require "restful_error/version"
 
-I18n.load_path += Dir["#{File.expand_path("../config/locales")}/*.yml"] if defined? I18n
-
 module RestfulError
+  module Helper
+    def restful
+      @restful ||= begin
+        raise NotImplementedError, "http_status must be implemented by including class" unless respond_to?(:http_status)
+        RestfulError.build_status_from_symbol_or_code(http_status)
+      end
+    end
+    def response_message
+      return @response_message unless @response_message.nil?
+      @response_message = RestfulError.localized_phrase(self.class.name, restful)
+    end
+  end
+
   class BaseError < StandardError
-    attr_reader :response_message
+    include RestfulError::Helper
     def initialize(message = nil)
       @response_message = message
       super
     end
   end
 
-  module Helper
-    def restful
-      raise NotImplementedError, "http_status must be implemented by including class" unless respond_to?(:http_status)
-
-      @restful ||= RestfulError.build_status_from_symbol_or_code(http_status)
-    end
-  end
-
   @cache = {}
   class << self
     def [](code_like)
@@ -38,10 +41,21 @@ def const_missing(const_name)
       @cache[status.code] ||= build_error_class_for(status)
     end
 
+    def init_i18n
+      return if @init_i18n
+      I18n.load_path += Dir["#{File.expand_path("./config/locales")}/*.yml"]
+      @init_i18n = true
+    end
+    def localized_phrase(class_name, status)
+      return false unless defined?(I18n)
+      init_i18n
+      class_key = RestfulError::Inflector.underscore(class_name)
+      I18n.t class_key, default: [status.symbol, false], scope: :restful_error
+    end
+
     private
 
     def build_error_class_for(status)
-      message = defined?(I18n) ? I18n.t(status.symbol, default: status.reason_phrase, scope: :restful_error) : status.reason_phrase
       klass = Class.new(BaseError) do
         define_method(:http_status) { status.code }
         define_method(:restful) { status }

lib/restful_error/railtie.rb

@@ -14,12 +14,7 @@ def show
       status = RestfulError.build_status_from_symbol_or_code(code)
       @status_code = status.code
       @reason_phrase = status.reason_phrase
-      @response_message = @exception.try(:response_message)
-      unless @response_message
-        class_name = @exception.class.name
-        class_key = RestfulError::Inflector.underscore(class_name)
-        @response_message = I18n.t class_key, default: [ status.symbol, '' ], scope: :restful_error
-      end
+      @response_message = @exception.try(:response_message) || RestfulError.localized_phrase(@exception.class.name, status) || nil
 
       self.status = status.code
       render "restful_error/show", formats: request.format.symbol

spec/with_rails/exceptions_app_spec.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require "action_controller"
-require "restful_error/railtie"
+require "i18n"
+require "spec_helper"
+require "restful_error/railtie" # require again for run after restful_error_spec
 
 RSpec.describe RestfulError::ExceptionsController do
   include Rack::Test::Methods
@@ -22,7 +23,7 @@ def app = RestfulError.exceptions_app
       context 'default message' do
         let(:exception) { described_class.new }
         it do
-          expect(json).to eq({status_code: 404, reason_phrase: "Not Found", response_message: ""}.stringify_keys)
+          expect(json).to eq({status_code: 404, reason_phrase: "Not Found", response_message: 'Page not found'}.stringify_keys)
           expect(last_response.status).to eq status_code
         end
       end
@@ -39,7 +40,7 @@ def app = RestfulError.exceptions_app
     let(:status_code) { 404 }
     include_context "json" do
       it do
-        expect(json).to eq({status_code:, reason_phrase: "Not Found", response_message: ""}.stringify_keys)
+        expect(json).to eq({status_code:, reason_phrase: "Not Found", response_message: 'Requested resource is not found'}.stringify_keys)
         expect(last_response.status).to eq status_code
       end
     end