String to Uri

[benkio]

I'm trying this method

sup/modules/http4s/src/main/scala/sup/modules/http4s.scala

Lines 19 to 22 in 9887f19

	def healthCheckRoutes[F[_]: Monad, H[_]: Reducible](
	healthCheck: HealthCheck[F, H],
	path: String = "health-check"
	)(

and I found that, overriding the path field, I can't put the health check route endpoint far from the root of the service, eg:

• "healthCheckFoo": resulting in localhost/myHealthcheck works, 200
• "bar/healthCheckFoo": doesn't work, 404

I think the parameter type should change, from String to Uri

[kubukoz]

hmm Uri has the problem that it could be absolute. While I agree the current state is problematic, I'm not convinced that's the best solution. Maybe a list of segments instead?

A workaround at the moment would be to wrap these routes in Router to add extra segments. e.g. Router("bar" -> healthCheckRoutes(..., "healthCheckFoo")).

@rossabaker what do you think about using Uri in this case?

[rossabaker]

A Uri.Path is basically just a Vector of segments that may or may not be absolute. Even if it is absolute, you can ignore that and append it to some other prefix. And you won't have schemes, authorities, etc. to discard.

[kubukoz]

oh, Uri.Path sounds great then. Thanks!

I'd add that, but keep the existing signature as well.