Skip to content

Commit d902714

Browse files
kensipealenkacz
andauthored
Fixes nil map bug on creation (#1743) (#1746)
Co-authored-by: Alena Varkockova <[email protected]> Signed-off-by: Ken Sipe <[email protected]>
1 parent f7fa143 commit d902714

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pkg/webhook/instance_admission.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,9 @@ func validateParameters(ov *kudoapi.OperatorVersion, instance *kudoapi.Instance)
464464
func setImmutableParameterDefaults(ov *kudoapi.OperatorVersion, instance *kudoapi.Instance) {
465465
for _, p := range ov.Spec.Parameters {
466466
if p.IsImmutable() && p.HasDefault() {
467+
if instance.Spec.Parameters == nil {
468+
instance.Spec.Parameters = map[string]string{}
469+
}
467470
if _, ok := instance.Spec.Parameters[p.Name]; !ok {
468471
instance.Spec.Parameters[p.Name] = *p.Default
469472
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
apiVersion: kudo.dev/v1beta1
22
kind: TestStep
33
commands:
4-
- command: sleep 10
4+
- command: sleep 20
55
- command: kubectl kudo init -v 4 --kudo-image kudobuilder/controller:test --kudo-image-pull-policy IfNotPresent --wait

0 commit comments

Comments
 (0)