Skip to content

Commit cffce0f

Browse files
github-actions[bot]create-or-update-pull-requestkuelumbus
authored
🤖 Bump RDKit version to Release_2024_03_5 (#108)
* Set RDKit version to Release_2024_03_5 * Bump to 2024_03_4 (#105) * Bump to 2024_03_4 * bump cmake to version 3.30.0 * set boost debug on * cmake to 2.29 * Add fix for finding boost::numpy target * Downgrade cmake to prevent issues with py3.8 and py3.9 * allow numpy 2.0 as install requirement * Reenable arm64 macos runners on GH actions * Bump github actions script * Copy libs to /usr/lib path on MacOS * Change permission of usr/lib dir * Copy all libs to other directory for MacOS * Fix stubs generation on MacOS * Fix freetype on macos * Fix conan detection bug for cp38 arm64 * Fix 3D descriptor test * Fix tests --------- Co-authored-by: Create or Update Pull Request Action <create-or-update-pull-request@users.noreply.github.com> Co-authored-by: Chris Kuenneth <44866753+kuelumbus@users.noreply.github.com> Co-authored-by: Christopher Kuenneth <christopher.kuenneth@gmail.com>
1 parent 7efa108 commit cffce0f

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from setuptools.command.build_ext import build_ext as build_ext_orig
1313

1414
# RDKit version to build (tag from github repository)
15-
rdkit_tag = "Release_2024_03_4"
15+
rdkit_tag = "Release_2024_03_5"
1616

1717
with open("README.md", "r", encoding="utf-8") as fh:
1818
long_description = fh.read()

tests/test_main.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import pytest
2+
13
def test_descriptor():
24
from rdkit.Chem import Descriptors
35
# Was 209 but changed to 211 in Release_2023_09_1
@@ -6,12 +8,17 @@ def test_descriptor():
68

79

810
def test_3d_descriptors():
11+
# from https://github.com/rdkit/rdkit/blob/master/rdkit/Chem/UnitTestDescriptors.py
912
from rdkit import Chem
1013
from rdkit.Chem import AllChem, Descriptors3D
1114

12-
m2 = Chem.AddHs(Chem.MolFromSmiles("CC"))
13-
AllChem.EmbedMolecule(m2, randomSeed=1)
14-
assert round(Descriptors3D.NPR1(m2), 10) == 0.2553516286
15+
mol = Chem.MolFromSmiles('CCCO')
16+
17+
# test function returns expected outputs
18+
AllChem.EmbedMolecule(mol, randomSeed=0xf00d)
19+
descs = Descriptors3D.CalcMolDescriptors3D(mol)
20+
assert 'InertialShapeFactor' in descs
21+
assert 20.9582649071385 == pytest.approx(descs['PMI1'], 1e-4)
1522

1623

1724
def test_data_dir_and_chemical_features():

0 commit comments

Comments
 (0)