Merge pull request #57 from kumaS-nu/develop

Add empty check

Author: kumaS-nu

NuGetImporterForUnity/Packages/NuGet Importer/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [3.3.1] - 2023-05-24
+
+- Fix occasional UI bugs
+
 ## [3.3.0] - 2023-05-22
 
 - Auto-generate Assembly Definition files for analyzers

NuGetImporterForUnity/Packages/NuGet Importer/Editor/DataClasses/StandardLibraries.cs

@@ -34,12 +34,15 @@ public static IList<string> PackageIds
         private static void GetDefaultUnityAssembly()
         {
             var projectPath = Path.GetDirectoryName(Application.dataPath).Replace("\\", "/");
-            Assembly playerAssembly = CompilationPipeline.GetAssemblies(AssembliesType.Player).First();
-            var standardRef = playerAssembly.compiledAssemblyReferences
+            Assembly playerAssembly = CompilationPipeline.GetAssemblies(AssembliesType.Player).FirstOrDefault();
+            if (playerAssembly != default)
+            {
+                var standardRef = playerAssembly.compiledAssemblyReferences
                                 .Select(p => p.Replace("\\", "/"))
                                 .Where(p => !p.StartsWith(projectPath)).Select(p => Path.GetFileNameWithoutExtension(p))
                                 .ToList();
-            packageIds = standardRef.AsReadOnly();
+                packageIds = standardRef.AsReadOnly();
+            }
             profile = PlayerSettings.GetApiCompatibilityLevel(EditorUserBuildSettings.selectedBuildTargetGroup);
         }
     }

NuGetImporterForUnity/Packages/NuGet Importer/Editor/NuGetImporterWindow.cs

@@ -285,8 +285,13 @@ internal void UpdateSelected(Catalog data)
             {
                 isAddedSummary = true;
             }
-            summary = new PackageSummary(data, PackageManager.Installed.package.First(package => package.id == data.items[0].items[0].catalogEntry.id).version);
-            deteal = data;
+            var package = PackageManager.Installed.package.Where(package => package.id == data.items[0].items[0].catalogEntry.id);
+            if (package != null && package.Any())
+            {
+                summary = new PackageSummary(data, package.First().version);
+                deteal = data;
+            }
+
             Repaint();
         }
 
@@ -391,7 +396,11 @@ internal async Task UpdateInstalledList()
                     foreach (KeyValuePair<string, Catalog> catalog in PackageManager.installedCatalog)
                     {
                         catalogs.Add(catalog.Value);
-                        tasks.Add(catalog.Value.GetIcon(PackageManager.installed.package.First(package => package.id == catalog.Value.items[0].items[0].catalogEntry.id).version));
+                        var package = PackageManager.Installed.package.Where(package => package.id == catalog.Value.items[0].items[0].catalogEntry.id);
+                        if (package != null && package.Any())
+                        {
+                            tasks.Add(catalog.Value.GetIcon(package.First().version));
+                        }
                     }
                 }
             }