Use nested routes for built-in gateways listeners

[schogges]

Description

Currently we append a query search param for the listener that is selected. This should rather be a path param:

Change /meshes/default/gateways/builtin/intent-0-e3e672bad-iqewg.kuma-system/overview?listener=0 to /meshes/default/gateways/builtin/intent-0-e3e672bad-iqewg.kuma-system/overview/listener=0 (note the ? turned into /).

This is the expected change and it may require some more changes in the code.

[jangirvipin]

Is there a need to move listener=0 from a query param to a dedicated route like /listener/0? Unless we have nested routes under that path (like /listener/0/config), wouldn't it be cleaner and simpler to keep it as a query parameter for filtering?

[johncowen]

Oh hey @jangirvipin 👋 sorry I've been AFK for a little while!

Is there a need to move listener=0 from a query param to a dedicated route like /listener/0? Unless we have nested routes under that path (like /listener/0/config), wouldn't it be cleaner and simpler to keep it as a query parameter for filtering?

We have a pattern in the GUI to only use query params for different views on the same document/data (for example filtering), as oppose to using them to show a new 'document'/piece of data. I believe the approach here is showing a list of data (listeners) and then clicking to show an individual piece of data (a listener). I guess like a list of blog posts and then clicking to see an individual blog post. So in my mind this means "use a route param" to me.

Technically, this all helps to split stuff up and organize also as instead of having the code for both the listing and the detail in the same route file, we can have a listing route file and a detail route file. I think also from a technical perspective it's unfortunate the we have to use an index (0) for the identifier, and whilst I don't have a tonne of content into this view, I would hope there is something more meaningful we can use for an identifier (although I might be wrong!)

[johncowen]

P.S. lemme know if you've commented on other PRs as I might have missed them, I can come back to you if you have 👍

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.