verify all mocks/types using OpenAPI

[johncowen]

Why

We want all our data (both in-app and mocks) to be verified and kept up-to-date according to correct OpenAPI schema. Some of our app and some of are mocks are verified using OpenAPI schema, but a lot aren't ...yet

What

As a first step towards this:

We have a few mocks files that use satisfies EntityType to verify that the mock is correct, or in our case sometimes "reverse-verify" that the OpenAPI spec is correct.

We should make sure we are doing this for every mock file we have, not only does this verify our mocks, but when we eventually get automatically synced OpenAPI specs it will also ensure our mocks are kept 100% up-to-date.

Shorter term it will also help us to find places in the OpenAPI specs that are possibly slightly incorrect so we can decide whether/how to resolve that.

A good PR to read / follow is #4234

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[johncowen]

Would be worth doing, but not right now - feel free to reopen if you disagree

[johncowen]

Reopening this as its the best issue to use for history although I'm not sure if its exactly what we need here, but the above linked PR contains the stuff we want