zsh-system-clipboard-vicmd-vi-yank differences

[kocv59]

zsh-system-clipboard-vicmd-vi-yank is used on yy to copy the whole line and selecting visual mode with v then y to copy. Is there a way to tell them apart? I'm trying to add a newline after yy but not v then y.

[doronbehar]

@kocv59 I'm not sure I understand exactly what do you wish to happen. It seems though like you read the source code, so maybe you'd like to share with us links like this:

zsh-system-clipboard/zsh-system-clipboard.zsh

Lines 119 to 127 in c506b63

	function zsh-system-clipboard-vicmd-vi-yank() {
	zle vi-yank
	if [[ "${KEYS}" == "y" && "${KEYMAP}" == 'viopp' ]]; then # A new line should be added to the end
	printf '%s\n' "$CUTBUFFER" | zsh-system-clipboard-set
	else
	printf '%s' "$CUTBUFFER" | zsh-system-clipboard-set
	fi
	}
	zle -N zsh-system-clipboard-vicmd-vi-yank

To better explain yourself?

[kocv59]

What command do I have to do to make KEYMAP equal viopp in that part of the code? All types of copying it's set to vicmd.

[doronbehar]

That KEYMAP variable is being set by ZSH, it is read only.

[doronbehar]

See:

https://zsh.sourceforge.io/Doc/Release/Zsh-Line-Editor.html#User_002dDefined-Widgets

[kocv59]

Do you notice the same issue? When I use 'yy' to copy an entire line and then paste it, a new line is added afterward, which is expected. However, if I enter visual mode with 'v' and select a few letters before pressing 'y', it also adds a new line after pasting, which shouldn't happen.

[doronbehar]

I don't experience this:

https://asciinema.org/a/OaxWuyhjbGYXX6QLTiCnhyVOA

But this could be an issue with your zsh-system-clipboard-get:

zsh-system-clipboard/zsh-system-clipboard.zsh

Lines 114 to 117 in c506b63

	function zsh-system-clipboard-get(){
	_zsh_system_clipboard_method_refresh
	zsh-system-clipboard-get-${_zsh_system_clipboard_method_current}
	}

Could you share which $ZSH_SYSTEM_CLIPBOARD_METHOD do you use?

[kocv59]

I am trying some changes to the code so it's my bug. Is the copy from visual mode ('v' then select letters then 'y') done in zsh-system-clipboard-vicmd-vi-yank()?

[doronbehar]

TBH, I'm not sure, because:

$ bindkey -M visual | grep zsh-system
"p" zsh-system-clipboard-visual-put-replace-selection
"x" zsh-system-clipboard-visual-vi-delete

And zsh-system-clipboard-vicmd-vi-yank is not mentioned here. It is mentioned here:

bindkey -M vicmd | grep zsh-system

[kocv59]

I tried to put echo commands in all the functions but I can't find where that copy is happening.

Another one is I don't know what to do to make yank-whole-line function run. If I use Y it's yank-eol and yy is vi-yank do you know how to do it?

[doronbehar]

I tried to put echo commands in all the functions but I can't find where that copy is happening.

TBH I'm not sure myself too. I'd recommend BTW to echo the debugging messages to a file, to not clutter the stdout of the shell you are testing.

Another one is I don't know what to do to make yank-whole-line function run.

The truth is, that this plugin is designed based upon the existing bindkey -M vicmd bindings that you get without loading this plugin. So I'd suggest to first make sure you understand the purpose of each pre-defined function in bindkey -M vicmd list, and locate the function you wish to fix.

[kocv59]

Best people to understand it are zsh maintainers do you know if they planned to include this feature? If they have vi mode maybe they will consider integrating it with clipboard because that's what vi mode does in other apps.

[doronbehar]

Maybe try their mailing list. You should be able to discuss it with them without referencing the particular usecase of this plugin. Please keep us posted with any updates! A link to the mailing list thread will be nice too :).

[kocv59]

I don't have mailing lists if someone else wants to post there feel free or I can add it as a feature if they have an issue tracker.