Fix mypy errors for paho-mqtt v2 and scripts

- Remove loop_stop(force=) calls (parameter removed in paho v2)
- Remove dead on_connack callback (on_connect handles CONNACK in v2)
- Add missing return statement in stream_cardata.py main()
- Fix Iterable→Sequence type for argparse.parse_args() compatibility

Author: renaudallard

custom_components/cardata/stream.py

@@ -147,25 +147,16 @@ def _done_callback(future: ConcurrentFuture[Any]) -> None:
         future = asyncio.run_coroutine_threadsafe(coro, self.hass.loop)
         future.add_done_callback(_done_callback)
 
-    def _safe_loop_stop(self, client: mqtt.Client, force: bool = False) -> None:
+    def _safe_loop_stop(self, client: mqtt.Client) -> None:
         """Safely stop the MQTT loop, handling any exceptions.
 
         This ensures cleanup continues even if loop_stop() fails, preventing
         resource leaks from zombie MQTT threads.
         """
         try:
-            if force:
-                client.loop_stop(force=True)
-            else:
-                client.loop_stop()
+            client.loop_stop()
         except Exception as err:
             _LOGGER.warning("Error stopping MQTT loop: %s", err)
-            # Try force stop as fallback
-            if not force:
-                try:
-                    client.loop_stop(force=True)
-                except Exception:
-                    pass
 
     async def async_start(self) -> None:
         # Acquire lock with timeout to prevent indefinite blocking
@@ -515,7 +506,7 @@ def _handle_connect(self, client: mqtt.Client, userdata, flags, rc) -> None:
             if rc == 5 and self._last_disconnect is not None and now - self._last_disconnect < 10:
                 if debug_enabled():
                     _LOGGER.debug("BMW MQTT connection refused shortly after disconnect; scheduling retry")
-                self._safe_loop_stop(client, force=True)
+                self._safe_loop_stop(client)
                 self._client = None
                 stream_reconnect.schedule_retry(self, 3)
                 return

scripts/fetch_cardata.py

@@ -32,7 +32,7 @@
 import json
 import sys
 from pathlib import Path
-from typing import Any, Dict, Iterable, Optional
+from typing import Any, Dict, Optional, Sequence
 
 import requests
 
@@ -134,7 +134,7 @@ def resolve_base_url(base_url: str, openapi_path: Optional[str], server_index: i
     return url
 
 
-def main(argv: Optional[Iterable[str]] = None) -> int:
+def main(argv: Optional[Sequence[str]] = None) -> int:
     parser = argparse.ArgumentParser(
         description=(
             "Fetch BMW CarData information using an access token."

scripts/stream_cardata.py

@@ -141,8 +141,8 @@ def main() -> int:
         client.loop_forever()
     except KeyboardInterrupt:
         print("Disconnected by user")
-        client.disconnect()
-        return 0
+    client.disconnect()
+    return 0
 
 
 if __name__ == "__main__":

scripts/stream_loop.py

@@ -135,7 +135,6 @@ def build_client(
     client.reconnect_delay_set(min_delay=5, max_delay=60)
 
     client.on_connect = on_connect
-    client.on_connack = on_connack
     client.on_message = on_message
     client.on_disconnect = on_disconnect
     client.on_subscribe = on_subscribe
@@ -167,10 +166,6 @@ def on_message(client: mqtt.Client, userdata, msg: mqtt.MQTTMessage):
     print(f"[{timestamp}] {msg.topic}: {payload}")
 
 
-def on_connack(client, userdata, reason_code, flags, properties):  # type: ignore[override]
-    print(f"CONNACK received: reason_code={reason_code}, flags={flags}")
-
-
 def on_disconnect(client: mqtt.Client, userdata, disconnect_flags, reason_code, properties=None):
     print(f"Disconnected from stream (flags={disconnect_flags}, reason={reason_code}).")
     if isinstance(userdata, dict):