Skip to content

feat: add queued toast notifications#1493

Open
SameDesu123 wants to merge 17 commits into
kwaroran:mainfrom
SameDesu123:feat/queued-toast-notifications
Open

feat: add queued toast notifications#1493
SameDesu123 wants to merge 17 commits into
kwaroran:mainfrom
SameDesu123:feat/queued-toast-notifications

Conversation

@SameDesu123

Copy link
Copy Markdown
Contributor

PR Checklist

  • Required Checks
    • Have you added type definitions?
    • Have you tested your changes?
    • Have you checked that it won't break any existing features?

Summary

Reworks short non-blocking alerts into a queued toast notification flow with explicit severity, position settings, dedupe, and aggregation.

Related Issues

Part of the replacement split for #1486. Depends on #1491 and #1492.

Changes

  • Redesigns toast presentation and adds a Display setting for notification position.
  • Adds typed toast severity and metadata for call sites.
  • Adds a bounded toast queue with dedupe and count aggregation.
  • Migrates short success alerts to non-blocking success toasts.
  • Clears loading/progress alerts before success toasts where needed.
  • Removes the legacy type: 'toast' alert path after the queue is in place.

Impact

Short success feedback becomes non-blocking and queued. Blocking modal, dialog, and progress alert behavior should remain unchanged.

Additional Notes

This is PR 3 of 4. Because this is a fork-to-upstream PR, it targets main directly and currently includes earlier split commits. After #1491 and #1492 merge, this branch should be rebased onto updated upstream/main to reduce the diff to the toast changes only.

Validation:

  • git diff --check upstream/main...HEAD
  • pnpm check
  • pnpm exec vitest run src/ts/toastQueue.test.ts src/ts/alertModel.test.ts

@SameDesu123

Copy link
Copy Markdown
Contributor Author

Actual diff for this PR: +972 -169

@SameDesu123 SameDesu123 marked this pull request as ready for review June 23, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant