refactor(catalog): remove connector config immutable check, allow partial update (#476)

移除了 connector_config 的不可变字段校验逻辑，放开对数据库、host等配置字段的修改限制，修改后旧资源会在下次发现对齐时标记为stale，新增对应测试用例验证更新行为

Co-authored-by: “Ken.li” <“Ken.li@kweaver.ai”>

Author: kenlee1988

adp/docs/api/vega/vega-backend-api/catalog.yaml

@@ -275,6 +275,9 @@ paths:
         `enabled` 不能通过 PUT 切换；请求体中的 `enabled` 必须与当前 catalog 状态一致。
         如需启用/禁用，使用 `POST /catalogs/{id}/enable` 或 `POST /catalogs/{id}/disable`。
 
+        `connector_config` 可修改；修改影响发现范围的字段后，旧 Resource 会在下一次
+        discover 对齐时标记为 `stale`。
+
         **extensions**：请求体若包含 **`extensions` 键**（含空对象 `{}`），则对该 catalog **整包替换**
         `t_entity_extension` 中 `f_entity_id = id` 的全部行；**键未出现**则不修改副表。
       requestBody:

adp/vega/vega-backend/server/driveradapters/catalog_handler.go

@@ -10,7 +10,6 @@ import (
 	"context"
 	"fmt"
 	"net/http"
-	"reflect"
 	"strconv"
 	"strings"
 	"vega-backend/common"
@@ -400,7 +399,6 @@ func (r *restHandler) updateCatalog(c *gin.Context, visitor hydra.Visitor) {
 		return
 	}
 
-	// Validate immutable fields
 	// connector_type cannot be modified
 	if req.ConnectorType != catalog.ConnectorType {
 		span.SetStatus(codes.Error, "Connector type cannot be modified")
@@ -419,47 +417,6 @@ func (r *restHandler) updateCatalog(c *gin.Context, visitor hydra.Visitor) {
 		return
 	}
 
-	// connector_config immutable fields: host, port, database, databases, schemas, paths, protocol
-	// These fields cannot be modified or removed if they exist in the original catalog
-	immutableFields := []string{"host", "port", "database", "databases", "schemas", "paths", "protocol", "concurrent"}
-	for _, field := range immutableFields {
-		if _, existsInCatalog := catalog.ConnectorCfg[field]; existsInCatalog {
-			if _, existsInReq := req.ConnectorCfg[field]; existsInReq {
-				// Field exists in both, check if it's being modified
-				// Handle different types: string, number, array
-				catalogValue := catalog.ConnectorCfg[field]
-				reqValue := req.ConnectorCfg[field]
-
-				var isModified bool
-				switch v := catalogValue.(type) {
-				case []interface{}:
-					// Compare arrays using reflect.DeepEqual
-					isModified = !reflect.DeepEqual(v, reqValue)
-				default:
-					// Compare other types (string, number, etc.)
-					isModified = (reqValue != catalogValue)
-				}
-
-				if isModified {
-					span.SetStatus(codes.Error, fmt.Sprintf("Connector config field %s cannot be modified", field))
-					httpErr := rest.NewHTTPError(ctx, http.StatusBadRequest, verrors.VegaBackend_Catalog_InvalidParameter_ConnectorConfig).
-						WithErrorDetails(fmt.Sprintf("connector_config.%s cannot be modified", field))
-					oteltrace.AddHttpAttrs4HttpError(span, httpErr)
-					rest.ReplyError(c, httpErr)
-					return
-				}
-			} else {
-				// Field exists in catalog but not in request - cannot remove immutable fields
-				span.SetStatus(codes.Error, fmt.Sprintf("Connector config field %s cannot be removed", field))
-				httpErr := rest.NewHTTPError(ctx, http.StatusBadRequest, verrors.VegaBackend_Catalog_InvalidParameter_ConnectorConfig).
-					WithErrorDetails(fmt.Sprintf("connector_config.%s cannot be removed", field))
-				oteltrace.AddHttpAttrs4HttpError(span, httpErr)
-				rest.ReplyError(c, httpErr)
-				return
-			}
-		}
-	}
-
 	// Apply updates
 	if req.Name != catalog.Name {
 		exists, err := r.cs.CheckExistByName(ctx, req.Name)

adp/vega/vega-backend/server/driveradapters/catalog_handler_test.go

@@ -210,6 +210,48 @@ func Test_CatalogRestHandler_UpdateRejectsEnabledChange(t *testing.T) {
 	})
 }
 
+func Test_CatalogRestHandler_UpdateAllowsDatabaseChange(t *testing.T) {
+	Convey("Test CatalogHandler Update allows database change\n", t, func() {
+		test := setGinMode()
+		defer test()
+
+		engine := gin.New()
+		engine.Use(gin.Recovery())
+
+		mockCtrl := gomock.NewController(t)
+		defer mockCtrl.Finish()
+
+		cs := vmock.NewMockCatalogService(mockCtrl)
+		handler := MockNewRestHandler(&common.AppSetting{}, nil, cs, nil, nil, nil, nil, nil, nil, nil, nil)
+		handler.RegisterPublic(engine)
+
+		cs.EXPECT().GetByID(gomock.Any(), "catalog-1", false).
+			Return(&interfaces.Catalog{
+				ID:            "catalog-1",
+				Name:          "catalog",
+				Enabled:       true,
+				ConnectorType: "mariadb",
+				ConnectorCfg: interfaces.ConnectorConfig{
+					"host":     "localhost",
+					"database": "db1",
+				},
+			}, nil)
+		cs.EXPECT().Update(gomock.Any(), gomock.Any(), gomock.Any()).
+			DoAndReturn(func(_ context.Context, _ *interfaces.Catalog, req *interfaces.CatalogRequest) error {
+				So(req.ConnectorCfg["database"], ShouldEqual, "db2")
+				return nil
+			})
+
+		body := `{"id":"catalog-1","name":"catalog","enabled":true,"connector_type":"mariadb","connector_config":{"host":"localhost","database":"db2"}}`
+		req := httptest.NewRequest(http.MethodPut, "/api/vega-backend/in/v1/catalogs/catalog-1", strings.NewReader(body))
+		req.Header.Set("Content-Type", "application/json")
+		w := httptest.NewRecorder()
+		engine.ServeHTTP(w, req)
+
+		So(w.Result().StatusCode, ShouldEqual, http.StatusNoContent)
+	})
+}
+
 func Test_CatalogRestHandler_DiscoverRejectsDisabledCatalog(t *testing.T) {
 	Convey("Test CatalogHandler Discover rejects disabled catalog\n", t, func() {
 		test := setGinMode()