Added validations to model file and added default value for status to schema/model for requests

Author: jonathankiichikimura

app/controllers/requests_controller.rb

@@ -1,49 +1,52 @@
 class RequestsController < ApplicationController
+  before_action :set_request, only: %i[show edit update]
+
   def index
     @requests = current_user.charity.requests
   end
 
   def show
-    @request = Request.find(params[:id])
   end
 
   def new
     @request = Request.new
   end
 
   def create
+    if current_user.charity.nil?
+      redirect_to root_path
+      return
+    end
     @request = Request.new(request_params)
     @request.charity = current_user.charity
-    if @request.save
-      redirect_to requests_path
-    else
-      render :new, status: :unprocessable_entity
-    end
+    @request.save ? redirect_to(requests_path) : render(:new, status: :unprocessable_entity)
   end
 
   def edit
-    @request = Request.find(params[:id])
   end
 
   def update
-    @request = Request.find(params[:id])
     if @request.update(request_params)
       redirect_to requests_path
     else
       render :edit, status: :unprocessable_entity
     end
   end
 
-  def activate
-  end
+  # def activate
+  # end
 
-  def deactivate
-  end
+  # def deactivate
+  # end
 
   private
 
+  def set_request
+    @request = Request.find(params[:id])
+  end
+
   def request_params
     params.require(:request).permit(:title, :category, :description, :quantity_needed, :quantity_remaining, :units,
-                                    :condition, :region, :city, :urgency, :status)
+                                    :condition, :region, :city, :urgency)
   end
 end

app/models/request.rb

@@ -1,4 +1,18 @@
 class Request < ApplicationRecord
   belongs_to :charity
   has_many :offers
+
+  STATUSES = %w[active inactive fulfilled]
+
+  after_initialize :set_default_status, if: :new_record?
+
+  validates :title, :category, :description, :units, :condition, :region, :city, :urgency, presence: true
+  validates :status, inclusion: { in: STATUSES }
+  validates :quantity_needed, :quantity_remaining, numericality: { greater_than_or_equal_to: 0 }
+
+  private
+
+  def set_default_status
+    self.status ||= "inactive"
+  end
 end

app/views/requests/_request_form.html.erb

@@ -1,6 +1,5 @@
 <%= simple_form_for request do |f| %>
   <%= f.input :title %>
-  <%= f.input :status %>
   <%= f.input :region %>
   <%= f.input :quantity_needed %>
   <%= f.input :quantity_remaining %>

db/migrate/20260409055108_add_default_status_to_requests.rb

@@ -0,0 +1,6 @@
+class AddDefaultStatusToRequests < ActiveRecord::Migration[8.1]
+  def change
+    change_column_default :requests, :status, from: nil, to: "inactive"
+    change_column_null :requests, :status, false, "inactive"
+  end
+end