fix: reject empty noninteractive agent tasks

Author: nightcityblade

swarms/structs/agent.py

@@ -4030,15 +4030,15 @@ def run(
             >>> agent.run("Describe this image", img=img_base64)
         """
 
-        # # If interactive mode is enabled and no task is provided, prompt the user
-        # if self.interactive and (
-        #     task is None
-        #     or (isinstance(task, str) and task.strip() == "")
-        if (
-            task is None
-            or isinstance(task, str)
-            and task.strip() == ""
-        ):
+        empty_task = task is None or (
+            isinstance(task, str) and task.strip() == ""
+        )
+        if empty_task and not self.interactive:
+            raise ValueError(
+                "A non-empty task is required when interactive mode is disabled."
+            )
+
+        if self.interactive and empty_task:
             # Always show prompt when asking for initial task, even if print_on is False
             self.pretty_print(
                 "Interactive mode enabled. Please enter your initial task:",

tests/structs/test_agent.py

@@ -136,6 +136,19 @@ def test_run_with_stopping_condition(
         response = flow_with_condition.run("Stop")
         assert response is not None
 
+    @pytest.mark.parametrize("task", [None, "", "   "])
+    def test_noninteractive_empty_task_does_not_read_stdin(
+        self, test_agent, task
+    ):
+        with (
+            patch(
+                "swarms.structs.agent.formatter.console.input",
+                side_effect=AssertionError("stdin must not be read"),
+            ),
+            pytest.raises(ValueError, match="non-empty task"),
+        ):
+            test_agent.run(task)
+
     def test_bulk_run(self, basic_flow):
         """Test bulk run functionality"""
         inputs = [{"task": "Test1"}, {"task": "Test2"}]