Skip to content

Commit 0441366

Browse files
committed
Merge branch 'main' of https://github.com/kyma-project/busola into post-conversations
2 parents d7bdadc + 508afa5 commit 0441366

File tree

8 files changed

+1870
-51
lines changed

8 files changed

+1870
-51
lines changed

.github/scripts/install-kyma.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ fi
1616

1717
# Create if not exist
1818
kubectl get ns kyma-system || kubectl create ns kyma-system
19+
kubectl get ns kcp-system || kubectl create ns kcp-system
1920

20-
./bin/kyma alpha deploy
21+
# ./bin/kyma alpha deploy
2122

2223
echo "Apply and enable keda module"
2324
kubectl apply -f https://github.com/kyma-project/keda-manager/releases/latest/download/keda-manager.yaml
@@ -47,6 +48,8 @@ kubectl apply -f https://github.com/kyma-project/telemetry-manager/releases/late
4748
kubectl apply -f https://github.com/kyma-project/telemetry-manager/releases/latest/download/telemetry-default-cr.yaml -n kyma-system
4849

4950
echo "Apply modules fixtures"
51+
kubectl apply -f tests/integration/fixtures/module-templates-crd.yaml
52+
kubectl apply -f tests/integration/fixtures/test-crd-kyma.yaml
5053
kubectl apply -f tests/integration/fixtures/modules
5154

5255
echo "Apply gardener resources"

src/components/KymaModules/KymaModulesEdit.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ export default function KymaModulesEdit({ resource, ...props }) {
285285
text={t('kyma-modules.managed')}
286286
checked={findModuleSpec(kymaResource, module.name)?.managed}
287287
onChange={event => {
288-
console.log(event);
289288
setManaged(event.target.checked, index);
290289
}}
291290
/>

src/components/KymaModules/KymaModulesList.js

Lines changed: 32 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,12 @@ export default function KymaModulesList({
222222
resource?.version,
223223
);
224224

225+
const moduleDocs =
226+
currentModuleTemplate?.spec?.info?.documentation ||
227+
currentModuleTemplate?.metadata?.annotations[
228+
'operator.kyma-project.io/doc-url'
229+
];
230+
225231
const currentModuleReleaseMeta = findModuleReleaseMeta(resource.name);
226232

227233
const isChannelOverriden =
@@ -254,7 +260,8 @@ export default function KymaModulesList({
254260
<>
255261
{moduleStatus?.channel
256262
? moduleStatus?.channel
257-
: kymaResource?.spec?.modules?.[moduleIndex]?.channel}
263+
: kymaResource?.spec?.modules?.[moduleIndex]?.channel ||
264+
kymaResource?.spec?.channel}
258265
{isChannelOverriden ? (
259266
<Tag
260267
hideStateIcon
@@ -281,17 +288,13 @@ export default function KymaModulesList({
281288
{moduleStatus?.state || 'Unknown'}
282289
</StatusBadge>,
283290
// Documentation
284-
<ExternalLink
285-
url={
286-
currentModuleTemplate?.spec?.info
287-
? currentModuleTemplate.spec.info.documentation
288-
: currentModuleTemplate?.metadata?.annotations[
289-
'operator.kyma-project.io/doc-url'
290-
]
291-
}
292-
>
293-
{t('common.headers.link')}
294-
</ExternalLink>,
291+
moduleDocs ? (
292+
<ExternalLink url={moduleDocs}>
293+
{t('common.headers.link')}
294+
</ExternalLink>
295+
) : (
296+
EMPTY_TEXT_PLACEHOLDER
297+
),
295298
];
296299
};
297300

@@ -495,6 +498,19 @@ export default function KymaModulesList({
495498
return false;
496499
};
497500

501+
function getEntries(statusModules = [], specModules = []) {
502+
specModules.forEach(specItem => {
503+
const exists = statusModules.some(
504+
statusItem => statusItem.name === specItem.name,
505+
);
506+
507+
if (!exists) {
508+
statusModules.push({ name: specItem.name });
509+
}
510+
});
511+
return statusModules;
512+
}
513+
498514
return (
499515
<React.Fragment key="modules-list">
500516
{!detailsOpen &&
@@ -588,7 +604,10 @@ export default function KymaModulesList({
588604
customColumnLayout={customColumnLayout}
589605
enableColumnLayout
590606
hasDetailsView
591-
entries={resource?.status?.modules}
607+
entries={getEntries(
608+
resource?.status?.modules,
609+
resource?.spec?.modules,
610+
)}
592611
headerRenderer={headerRenderer}
593612
rowRenderer={rowRenderer}
594613
noHideFields={['Name', '', 'Namespace']}

src/shared/components/GenericList/GenericList.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,13 @@ export const GenericList = ({
124124
const [searchQuery, setSearchQuery] = useState('');
125125

126126
useEffect(() => {
127-
if (pagination) {
128-
// move back when the last item from the last page is deleted
129-
const pagesCount = Math.ceil(entries.length / pagination.itemsPerPage);
130-
if (currentPage > pagesCount && pagesCount > 0) {
131-
setCurrentPage(pagesCount);
127+
if (entries.length > 0) {
128+
if (pagination) {
129+
// move back when the last item from the last page is deleted
130+
const pagesCount = Math.ceil(entries.length / pagination.itemsPerPage);
131+
if (currentPage > pagesCount && pagesCount > 0) {
132+
setCurrentPage(pagesCount);
133+
}
132134
}
133135
}
134136
setFilteredEntries(

0 commit comments

Comments
 (0)