Skip to content

Commit 0bace38

Browse files
authored
fix: theme on initial and refresh (#3565)
1 parent 589bf60 commit 0bace38

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

src/components/App/App.tsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,38 +19,38 @@ import { useGetConfiguration } from 'state/configuration/configurationAtom';
1919
import { useGetExtensions } from 'state/navigation/extensionsAtom';
2020
import { useGetExtensibilitySchemas } from 'state/extensibilitySchemasAtom';
2121
import { useGetValidationSchemas } from 'state/validationSchemasAtom';
22-
2322
import { useLoginWithKubeconfigID } from 'components/App/useLoginWithKubeconfigID';
2423
import { useMakeGardenerLoginRoute } from 'components/Gardener/useMakeGardenerLoginRoute';
2524
import { useHandleResetEndpoint } from 'components/Clusters/shared';
26-
import { Preferences } from 'components/Preferences/Preferences';
2725
import { useResourceSchemas } from './resourceSchemas/useResourceSchemas';
26+
import { useAfterInitHook } from 'state/useAfterInitHook';
27+
import useSidebarCondensed from 'sidebar/useSidebarCondensed';
28+
import { useGetValidationEnabledSchemas } from 'state/validationEnabledSchemasAtom';
29+
import { useGetKymaResources } from 'state/kymaResourcesAtom';
30+
31+
import { Preferences } from 'components/Preferences/Preferences';
2832
import { Header } from 'header/Header';
2933
import { ContentWrapper } from './ContentWrapper/ContentWrapper';
3034
import { Sidebar } from 'sidebar/Sidebar';
31-
import { useInitTheme } from './useInitTheme';
3235
import ClusterList from 'components/Clusters/views/ClusterList';
3336
import ClusterRoutes from './ClusterRoutes';
34-
3537
import { IncorrectPath } from './IncorrectPath';
38+
import { Spinner } from 'shared/components/Spinner/Spinner';
39+
40+
import { themeState } from 'state/preferences/themeAtom';
41+
import { initTheme } from './initTheme';
3642

3743
import './App.scss';
38-
import { useAfterInitHook } from 'state/useAfterInitHook';
39-
import useSidebarCondensed from 'sidebar/useSidebarCondensed';
40-
import { useGetValidationEnabledSchemas } from 'state/validationEnabledSchemasAtom';
41-
import { useGetKymaResources } from 'state/kymaResourcesAtom';
42-
import { Spinner } from 'shared/components/Spinner/Spinner';
4344

4445
export default function App() {
46+
const theme = useRecoilValue(themeState);
4547
const language = useRecoilValue(languageAtom);
4648
const cluster = useRecoilValue(clusterState);
4749
const setNamespace = useSetRecoilState(activeNamespaceIdState);
4850
const { namespace } = useUrl();
4951
const makeGardenerLoginRoute = useMakeGardenerLoginRoute();
5052
const { t, i18n } = useTranslation();
5153

52-
useInitTheme();
53-
5454
useEffect(() => {
5555
setNamespace(namespace);
5656
}, [setNamespace, namespace]);
@@ -80,6 +80,8 @@ export default function App() {
8080
return <Spinner />;
8181
}
8282

83+
initTheme(theme);
84+
8385
return (
8486
<div id="html-wrap">
8587
<Header />
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
import { useRecoilValue } from 'recoil';
2-
import { isSystemThemeDark, themeState } from 'state/preferences/themeAtom';
1+
import { isSystemThemeDark } from 'state/preferences/themeAtom';
32
import { setTheme } from '@ui5/webcomponents-base/dist/config/Theme';
43

54
// you must initially load the themeState to
65
//let the App know what theme to choose
7-
export const useInitTheme = () => {
8-
const theme = useRecoilValue(themeState);
6+
export const initTheme = (theme: string) => {
97
if (theme === 'light_dark') {
108
if (isSystemThemeDark()) setTheme('sap_horizon_dark');
119
else setTheme('sap_horizon');

0 commit comments

Comments
 (0)