chore: Fix @typescript-eslint/no-non-null-asserted-optional-chain' (#4427)

* fix

* throw exceptions

Author: dbadura

eslint.config.ts

@@ -52,7 +52,6 @@ export default defineConfig(
           },
         ],
         '@typescript-eslint/no-empty-object-type': 'off',
-        '@typescript-eslint/no-non-null-asserted-optional-chain': 'warn',
         '@typescript-eslint/no-unsafe-function-type': 'warn',
         '@typescript-eslint/no-unused-expressions': 'warn',
         '@typescript-eslint/ban-ts-comment': 'error',

src/components/Clusters/shared.ts

@@ -114,7 +114,8 @@ export function getUserIndex(kubeconfig?: Kubeconfig) {
     contextName === '-all-'
       ? kubeconfig?.contexts?.[0]?.context
       : kubeconfig?.contexts?.find((c) => c?.name === contextName)?.context;
-  const index = kubeconfig?.users?.findIndex((u) => u?.name === context?.user)!;
+  const index =
+    kubeconfig?.users?.findIndex((u) => u?.name === context?.user) || -1;
   return index > 0 ? index : 0;
 }
 

src/state/authDataAtom.ts

@@ -37,6 +37,19 @@ type handleLoginProps = {
   onError: () => void;
 };
 
+function getToken(user: User | null, useAccessToken: boolean): string {
+  if (!user) {
+    throw new Error('user is null');
+  }
+  if (useAccessToken) {
+    return user.access_token;
+  }
+  if (user.id_token) {
+    return user.id_token;
+  }
+  throw new Error('id_token is empty');
+}
+
 export function createUserManager(
   oidcParams: {
     issuerUrl: string;
@@ -75,7 +88,7 @@ async function handleLogin({
     userManager.events.addAccessTokenExpiring(async () => {
       const user = await userManager.signinSilent();
       setAuth({
-        token: useAccessToken ? user?.access_token! : user?.id_token!,
+        token: getToken(user, useAccessToken),
       });
     });
     userManager.events.addSilentRenewError((e) => {
@@ -95,7 +108,7 @@ async function handleLogin({
         if (!!user?.expired || (user?.expires_in && user?.expires_in <= 2)) {
           user = await userManager.signinSilent();
           setAuth({
-            token: useAccessToken ? user?.access_token! : user?.id_token!,
+            token: getToken(user, useAccessToken),
           });
         }
       }
@@ -113,7 +126,7 @@ async function handleLogin({
       storedUser && !storedUser.expired
         ? storedUser
         : await userManager.signinRedirectCallback(window.location.href);
-    setAuth({ token: useAccessToken ? user?.access_token : user?.id_token! });
+    setAuth({ token: getToken(user, useAccessToken) });
     setupAuthEventsHooks(userManager, useAccessToken);
     setupVisibilityEventsHooks(userManager, user, useAccessToken);
     onAfterLogin();