Skip to content

Commit 131aed1

Browse files
committed
Review fixes
1 parent cd95ec0 commit 131aed1

File tree

4 files changed

+15
-25
lines changed

4 files changed

+15
-25
lines changed

src/command-pallette/CommandPalletteUI/CommandPaletteSearchBar.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ export function CommandPaletteSearchBar({
8989
});
9090

9191
if (htmlWrapEl) {
92-
// elementObserver.observe(shellbarRef.current);
9392
elementObserver.observe(htmlWrapEl);
9493
}
9594
return () => {

src/command-pallette/CommandPalletteUI/CommandPaletteUI.scss

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,14 @@
4141
display: none;
4242
}
4343
}
44-
}
4544

46-
.command-palette-ui {
47-
@media (max-width: 1040px) {
48-
&__wrapper {
49-
width: 100%;
50-
max-width: unset;
51-
height: 100%;
52-
opacity: 100%;
53-
}
45+
&__wrapper.full-size {
46+
width: 100%;
47+
max-width: unset;
48+
height: 100%;
49+
opacity: 100%;
5450

5551
.input-container {
56-
display: flex;
57-
flex-direction: row;
58-
align-items: center;
59-
6052
.search-with-display-more {
6153
margin-right: 2.5rem;
6254
}
@@ -70,18 +62,16 @@
7062
}
7163
}
7264

73-
.command-palette-ui {
74-
&__wrapper.full-size {
75-
width: 100%;
76-
max-width: unset;
77-
height: 100%;
78-
opacity: 100%;
65+
@media (max-width: 1040px) {
66+
.command-palette-ui {
67+
&__wrapper {
68+
width: 100%;
69+
max-width: unset;
70+
height: 100%;
71+
opacity: 100%;
72+
}
7973

8074
.input-container {
81-
display: flex;
82-
flex-direction: row;
83-
align-items: center;
84-
8575
.search-with-display-more {
8676
margin-right: 2.5rem;
8777
}

src/command-pallette/CommandPalletteUI/CommandPaletteUI.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export function CommandPaletteUI({
126126
paletteCurrent.style.right = '0px';
127127
paletteCurrent.style.left = '0px';
128128
}
129-
}, [showCommandPalette, shellbarWidth, showCommandPalette]); // eslint-disable-line react-hooks/exhaustive-deps
129+
}, [showCommandPalette, shellbarWidth]); // eslint-disable-line react-hooks/exhaustive-deps
130130

131131
const commandPaletteInput = document.getElementById('command-palette-search');
132132

src/header/Header.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
ui5-shellbar.header {
77
padding: 0 !important;
88
border-radius: 0.5rem;
9+
container-type: inline-size;
910

1011
&::part(root) {
1112
padding-inline-start: 0.75rem;

0 commit comments

Comments
 (0)