Skip to content

Commit 1cc5103

Browse files
authored
fix: Card no accessible name (#4084)
* fix: Card no accessible name * Fix placement
1 parent 6c3aee1 commit 1cc5103

File tree

17 files changed

+38
-5
lines changed

17 files changed

+38
-5
lines changed

src/components/Clusters/views/ClusterOverview/ClusterStats.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ export default function ClusterStats({ nodesData }) {
120120
<div className="item-wrapper card-tall">
121121
<Card
122122
className="radial-chart-card item"
123+
accessibleName={t('cluster-overview.statistics.cpu-usage')}
123124
header={
124125
<CardHeader
125126
titleText={t('cluster-overview.statistics.cpu-usage')}
@@ -153,6 +154,7 @@ export default function ClusterStats({ nodesData }) {
153154
<div className="item-wrapper card-tall">
154155
<Card
155156
className="radial-chart-card item"
157+
accessibleName={t('cluster-overview.statistics.memory-usage')}
156158
header={
157159
<CardHeader
158160
titleText={t('cluster-overview.statistics.memory-usage')}

src/components/Clusters/views/ClusterOverview/ClusterValidation/ClusterValidation.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ export const ClusterValidation = () => {
243243
const InfoTile = ({ title, content }: { title?: string; content?: string }) => {
244244
return (
245245
<Card
246+
accessibleName={title}
246247
header={<CardHeader titleText={title} subtitleText={content} />}
247248
style={{ width: 'fit-content', margin: '5px' }}
248249
></Card>
@@ -265,6 +266,7 @@ const Section = ({
265266
return (
266267
<FlexBox alignItems="Center" justifyContent="Center">
267268
<Card
269+
accessibleName={titleText}
268270
header={
269271
titleText ?? subtitleText ?? status ? (
270272
<CardHeader

src/components/Clusters/views/ClusterOverview/ClusterValidation/ScanConfiguration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const systemNamespaces = [
1616
];
1717

1818
export const getDefaultScanConfiguration = (
19-
namespaces: string[],
19+
namespaces: string[] | null,
2020
policies: string[],
2121
): ScanConfiguration => {
2222
const userNamespaces =

src/components/Extensibility/components/RadialChart.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export const RadialChart = ({ structure, value, originalResource }) => {
3535
<div className="item-wrapper card-tall">
3636
<Card
3737
className="radial-chart-card"
38+
accessibleName={t(structure?.name)}
3839
header={<CardHeader titleText={t(structure?.name)} />}
3940
>
4041
<UI5RadialChart

src/components/KymaCompanion/components/KymaCompanion.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ export default function KymaCompanion() {
5858
<div id="companion_wrapper">
5959
<Card
6060
className="kyma-companion"
61+
accessibleName={t('kyma-companion.name')}
6162
header={
6263
<div
6364
className={`kyma-companion__${

src/components/Modules/community/components/CommunityModuleCard.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@ export default function CommunityModuleCard({
5252
}, [module]);
5353

5454
return (
55-
<Card key={`card-${module.name}`} className="addModuleCard">
55+
<Card
56+
accessibleName={module.name}
57+
key={`card-${module.name}`}
58+
className="addModuleCard"
59+
>
5660
<ListItemStandard
5761
className="moduleCardHeader"
5862
key={`list-${module.name}`}

src/components/Modules/components/ModulesCard.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,11 @@ export default function ModulesCard({
100100
};
101101

102102
return (
103-
<Card key={module.name} className="addModuleCard">
103+
<Card
104+
accessibleName={module.name}
105+
key={module.name}
106+
className="addModuleCard"
107+
>
104108
<ListItemStandard
105109
className="moduleCardHeader"
106110
onClick={() => {

src/components/Nodes/NodeResources/NodeResources.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export function NodeResources({ metrics, resources }) {
1515
<>
1616
<Card
1717
className="radial-chart-card"
18+
accessibleName={t('cluster-overview.statistics.cpu-usage')}
1819
header={
1920
<CardHeader titleText={t('cluster-overview.statistics.cpu-usage')} />
2021
}
@@ -36,6 +37,7 @@ export function NodeResources({ metrics, resources }) {
3637
</Card>
3738
<Card
3839
className="radial-chart-card"
40+
accessibleName={t('cluster-overview.statistics.memory-usage')}
3941
header={
4042
<CardHeader
4143
titleText={t('cluster-overview.statistics.memory-usage')}
@@ -53,6 +55,7 @@ export function NodeResources({ metrics, resources }) {
5355
</Card>
5456
<Card
5557
className="radial-chart-card"
58+
accessibleName={t('cluster-overview.statistics.cpu-requests')}
5659
header={
5760
<CardHeader
5861
titleText={t('cluster-overview.statistics.cpu-requests')}
@@ -84,6 +87,7 @@ export function NodeResources({ metrics, resources }) {
8487
</Card>
8588
<Card
8689
className="radial-chart-card"
90+
accessibleName={t('cluster-overview.statistics.memory-requests')}
8791
header={
8892
<CardHeader
8993
titleText={t('cluster-overview.statistics.memory-requests')}
@@ -105,6 +109,7 @@ export function NodeResources({ metrics, resources }) {
105109
</Card>
106110
<Card
107111
className="radial-chart-card"
112+
accessibleName={t('cluster-overview.statistics.cpu-limits')}
108113
header={
109114
<CardHeader titleText={t('cluster-overview.statistics.cpu-limits')} />
110115
}
@@ -134,6 +139,7 @@ export function NodeResources({ metrics, resources }) {
134139
</Card>
135140
<Card
136141
className="radial-chart-card"
142+
accessibleName={t('cluster-overview.statistics.memory-limits')}
137143
header={
138144
<CardHeader
139145
titleText={t('cluster-overview.statistics.memory-limits')}

src/resources/Namespaces/ResourcesUsage.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export const ResourcesUsage = ({ namespace }) => {
2323
return (
2424
<div className="item-wrapper card-small pods-metrics-error">
2525
<Card
26+
accessibleName={t('namespaces.overview.resources.error')}
2627
className="item"
2728
header={
2829
<CardHeader titleText={t('namespaces.overview.resources.error')} />
@@ -36,6 +37,7 @@ export const ResourcesUsage = ({ namespace }) => {
3637
<>
3738
<div className="item-wrapper card-tall">
3839
<Card
40+
accessibleName={t('cluster-overview.statistics.cpu-usage')}
3941
className="radial-chart-card item"
4042
header={
4143
<CardHeader
@@ -69,6 +71,7 @@ export const ResourcesUsage = ({ namespace }) => {
6971
</div>
7072
<div className="item-wrapper card-tall">
7173
<Card
74+
accessibleName={t('cluster-overview.statistics.memory-usage')}
7275
className="radial-chart-card item"
7376
header={
7477
<CardHeader

src/resources/Namespaces/YamlUpload/YamlResourcesList.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ export function YamlResourcesList({ resourcesData }) {
135135
}}
136136
>
137137
<Card
138+
accessibleName={t('upload-yaml.upload-progress')}
138139
header={
139140
<CardHeader
140141
titleText={t('upload-yaml.upload-progress')}

0 commit comments

Comments
 (0)