Skip to content

Commit 386038c

Browse files
authored
fix: Standardize tab names and icon (#4537)
* fix: Standardize tab names and icon * fix: namespaces titles
1 parent 5a43449 commit 386038c

File tree

8 files changed

+8
-4
lines changed

8 files changed

+8
-4
lines changed

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
object-src 'self';
3030
"
3131
/>
32-
<title>Busola</title>
32+
<title>Kyma Dashboard</title>
3333
</head>
3434

3535
<body class="ui5-content-native-scrollbars ui5-content-density-compact">

public/assets/favicon-16x16.png

-416 Bytes
Loading

public/assets/favicon-32x32.png

-321 Bytes
Loading

public/i18n/en.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,13 +1013,13 @@ namespaces:
10131013
description: <0>Namespace</0> helps to maintain and divide resources in a cluster.
10141014
name_singular: Namespace
10151015
namespace-overview: Namespace Overview
1016+
namespaces-overview: Namespaces Overview
10161017
overview:
10171018
resources:
10181019
error: Error while loading memory consumption data
10191020
limits: Memory Limits
10201021
requests: Memory Requests
10211022
title: Resource Consumption
1022-
title: Overview
10231023
title: Namespaces
10241024
navigation:
10251025
all-namespaces: All Namespaces

src/components/Clusters/views/ClusterList.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import { useNavigate } from 'react-router';
3232
import { createPortal } from 'react-dom';
3333

3434
import './ClusterList.scss';
35+
import { useWindowTitle } from 'shared/hooks/useWindowTitle';
3536

3637
function ClusterList() {
3738
const gardenerLoginFeature = useFeature(configFeaturesNames.GARDENER_LOGIN);
@@ -42,6 +43,7 @@ function ClusterList() {
4243
const notification = useNotification();
4344
const navigate = useNavigate();
4445
const { t } = useTranslation();
46+
useWindowTitle(t('clusters.labels.name'));
4547

4648
const [DeleteMessageBox, handleResourceDelete] = useDeleteResource({
4749
resourceType: t('clusters.labels.name'),

src/resources/Namespaces/AllNamespacesDetails.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ import { createPortal } from 'react-dom';
1111
import YamlUploadDialog from './YamlUpload/YamlUploadDialog';
1212
import { showYamlUploadDialogAtom } from 'state/showYamlUploadDialogAtom';
1313
import { useSetAtom } from 'jotai';
14+
import { useWindowTitle } from 'shared/hooks/useWindowTitle';
1415
import './AllNamespaceDetails.scss';
1516

1617
export function AllNamespacesDetails() {
1718
const { t } = useTranslation();
1819
const setShowAdd = useSetAtom(showYamlUploadDialogAtom);
20+
useWindowTitle(t('namespaces.namespaces-overview'));
1921

2022
const limitRangesParams = {
2123
hasDetailsView: true,

src/resources/Namespaces/NamespaceDetails.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export default function NamespaceDetails(props) {
8181
description={ResourceDescription}
8282
{...props}
8383
title={t('namespaces.namespace-overview')}
84-
windowTitle={t('namespaces.overview.title')}
84+
windowTitle={t('namespaces.namespace-overview')}
8585
customColumns={customColumns}
8686
headerActions={headerActions}
8787
customHealthCards={[

src/shared/hooks/useWindowTitle.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export function useWindowTitle(title, { skip } = {}) {
44
useEffect(() => {
55
const oldTitle = document.title;
66
if (!skip) {
7-
document.title = title;
7+
document.title = title + ' - Kyma Dashboard';
88
return () => (document.title = oldTitle);
99
}
1010
}, [title, skip]);

0 commit comments

Comments
 (0)