Skip to content

Commit 3888a2a

Browse files
authored
fix: Checkmarx issues (#4070)
* fix: Checkmarx issues * fix: Checkmarx issues * fix: Checkmarx issues * fix: Checkmarx issues
1 parent 56728fd commit 3888a2a

File tree

3 files changed

+32
-5
lines changed

3 files changed

+32
-5
lines changed

src/components/KymaCompanion/components/AIBanner/AIBanner.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ export function AIBanner({
6767
key="ai-feedback"
6868
endIcon="inspect"
6969
onClick={() => {
70-
window.open(feedbackUrl, '_blank');
70+
const newWindow = window.open(
71+
feedbackUrl,
72+
'_blank',
73+
'noopener, noreferrer',
74+
);
75+
if (newWindow) newWindow.opener = null;
7176
}}
7277
>
7378
{t('feedback.give-feedback')}
@@ -76,7 +81,12 @@ export function AIBanner({
7681
key="ai-documentation"
7782
endIcon="inspect"
7883
onClick={() => {
79-
window.open(documentationUrl, '_blank');
84+
const newWindow = window.open(
85+
documentationUrl,
86+
'_blank',
87+
'noopener, noreferrer',
88+
);
89+
if (newWindow) newWindow.opener = null;
8090
}}
8191
>
8292
{t('kyma-companion.banner.buttons.documentation')}

src/components/KymaCompanion/components/Chat/FeedbackMessage/FeedbackMessage.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,12 @@ export default function FeedbackMessage(): JSX.Element {
3030
endIcon="inspect"
3131
design="Emphasized"
3232
onClick={() => {
33-
window.open(companionConfig?.feedbackLink, '_blank');
33+
const newWindow = window.open(
34+
companionConfig?.feedbackLink,
35+
'_blank',
36+
'noopener, noreferrer',
37+
);
38+
if (newWindow) newWindow.opener = null;
3439
}}
3540
>
3641
{t('feedback.give-feedback')}

src/header/Feedback/FeedbackPopover.tsx

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,12 @@ export default function FeedbackPopover() {
117117
endIcon="inspect"
118118
onClick={() => {
119119
handleNewFeedbackViewed();
120-
window.open(companionFeedbackLink, '_blank');
120+
const newWindow = window.open(
121+
companionFeedbackLink,
122+
'_blank',
123+
'noopener, noreferrer',
124+
);
125+
if (newWindow) newWindow.opener = null;
121126
}}
122127
>
123128
{t('feedback.give-feedback')}
@@ -141,7 +146,14 @@ export default function FeedbackPopover() {
141146
? 'Emphasized'
142147
: 'Default'
143148
}
144-
onClick={() => window.open(kymaFeedbackLink, '_blank')}
149+
onClick={() => {
150+
const newWindow = window.open(
151+
kymaFeedbackLink,
152+
'_blank',
153+
'noopener, noreferrer',
154+
);
155+
if (newWindow) newWindow.opener = null;
156+
}}
145157
>
146158
{t('feedback.give-feedback')}
147159
</Button>

0 commit comments

Comments
 (0)