Skip to content

Commit 401811c

Browse files
committed
fix: fix refresh and create opening
1 parent c9f23d5 commit 401811c

File tree

4 files changed

+19
-6
lines changed

4 files changed

+19
-6
lines changed

src/shared/ResourceForm/useCreateResource.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export function useCreateResource({
7777
...layoutColumn,
7878
layout: nextLayout,
7979
showCreate: null,
80+
showEdit: null,
8081
midColumn: {
8182
resourceName: resource.metadata.name,
8283
resourceType: resource.kind,
@@ -90,6 +91,7 @@ export function useCreateResource({
9091
...layoutColumn,
9192
layout: nextLayout,
9293
showCreate: null,
94+
showEdit: null,
9395
endColumn: {
9496
resourceName: resource.metadata.name,
9597
resourceType: resource.kind,

src/shared/components/DynamicPageComponent/DynamicPageComponent.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,11 @@ export const DynamicPageComponent = ({
372372
setLayoutColumn({
373373
...layoutColumn,
374374
showEdit: {
375-
...(layoutColumn.endColumn ??
376-
layoutColumn.midColumn ??
377-
layoutColumn.startColumn),
375+
...(layoutNumber === 'EndColumn'
376+
? layoutColumn.endColumn
377+
: layoutNumber === 'MidColumn'
378+
? layoutColumn.midColumn
379+
: layoutColumn.startColumn),
378380
resource: null,
379381
},
380382
});

src/shared/components/ResourcesList/ResourcesList.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ export function ResourceListRenderer({
354354
namespaceId: namespace,
355355
resource: activeResource,
356356
},
357+
showEdit: null,
357358
layout: 'ThreeColumnsEndExpanded',
358359
}
359360
: {
@@ -365,6 +366,7 @@ export function ResourceListRenderer({
365366
namespaceId: namespace,
366367
resource: activeResource,
367368
},
369+
showEdit: null,
368370
layout: 'TwoColumnsMidExpanded',
369371
},
370372
);
@@ -444,6 +446,7 @@ export function ResourceListRenderer({
444446
resourceType: layoutState?.midColumn.resourceName,
445447
namespaceId: namespace,
446448
},
449+
showEdit: null,
447450
layout: 'ThreeColumnsEndExpanded',
448451
}
449452
: {
@@ -454,6 +457,7 @@ export function ResourceListRenderer({
454457
resourceType: resourceType,
455458
namespaceId: namespace,
456459
},
460+
showEdit: null,
457461
layout: 'TwoColumnsMidExpanded',
458462
},
459463
);

src/shared/hooks/usePrepareLayout.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
useNavigationType,
55
useSearchParams,
66
} from 'react-router-dom';
7-
import { useSetRecoilState } from 'recoil';
7+
import { useRecoilValue, useSetRecoilState } from 'recoil';
88
import { columnLayoutState } from 'state/columnLayoutAtom';
99
import { isFormOpenState } from 'state/formOpenAtom';
1010

@@ -92,6 +92,7 @@ export function usePrepareLayoutColumns({
9292
}) {
9393
const setLayoutColumn = useSetRecoilState(columnLayoutState);
9494
const setIsFormOpen = useSetRecoilState(isFormOpenState);
95+
const isFormOpen = useRecoilValue(isFormOpenState);
9596
const [searchParams] = useSearchParams();
9697
const layout = searchParams.get('layout');
9798
const showCreate = searchParams.get('showCreate');
@@ -204,13 +205,17 @@ export function usePrepareLayoutColumns({
204205
useEffect(() => {
205206
if (navigationType === NavigationType.Pop) {
206207
setLayoutColumn(newLayoutState);
207-
setIsFormOpen({ formOpen: !!newLayoutState.showCreate });
208+
setIsFormOpen({
209+
formOpen: !!newLayoutState.showCreate || !!newLayoutState.showEdit,
210+
});
208211
}
209212
}, [newLayoutState, setLayoutColumn, setIsFormOpen, navigationType]);
210213

211214
useEffect(() => {
212215
setLayoutColumn(newLayoutState);
213-
setIsFormOpen({ formOpen: !!newLayoutState.showCreate });
216+
setIsFormOpen({
217+
formOpen: !!newLayoutState.showCreate || !!newLayoutState.showEdit,
218+
});
214219
// eslint-disable-next-line react-hooks/exhaustive-deps
215220
}, []);
216221
}

0 commit comments

Comments
 (0)